feat: trigger create_release_pr on RC release branches - #1906
Merged
Conversation
Add release-candidate bump tokens (major-rc, minor-rc, patch-rc, rc, rc-release) to the create_release_pr.yaml template push triggers for the main, master and release bases. Without these, repos generated by devctl never start a release PR when an RC branch like main#release#minor-rc is pushed, so RC releases couldn't be cut the way stable ones are. Explicit-version and maintenance-branch patterns are unchanged: their 'v*.*.*' globs already match RC versions such as v2.1.0-rc.1. Requires the matching reusable-workflow support in giantswarm/github-workflows#195. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
piontec
changed the title
uvegla
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds release-candidate bump tokens to the
create_release_pr.yamltemplate'spushtriggers for themain,master, andreleasebases:<base>#release#major-rc<base>#release#minor-rc<base>#release#patch-rc<base>#release#rc<base>#release#rc-releaseWhy
Repos generated by devctl never start a release PR when an RC branch like
main#release#minor-rcis pushed, because the template only listed the stablemajor/minor/patchtokens. As a result RC releases couldn't be cut the same way stable ones are.The explicit-version and maintenance-branch patterns are intentionally left unchanged — their
v*.*.*globs already match RC versions such asv2.1.0-rc.1.Following repo convention, this changes the template + CHANGELOG only; the
.shasidecar and the regeneratedzz_generated.*files are updated separately by the automated "Align files" runs.Related
Requires the matching reusable-workflow support (RC handling in
create-release-pr.yaml,validate-changelog.yaml, andcreate-release.yaml): giantswarm/github-workflows#195Verified end-to-end against
giantswarm/release-test-app: pushingmain#release#rcopened a correctly-titledchore(release): v2.1.0-rc.2PR, the changelog check passed, and on merge the release was tagged and published as a GitHub pre-release.🤖 Generated with Claude Code