Skip to content

fix(docs): re-vendor the platform tokens the docs skin had fallen behind - #104

Merged
gianlucamazza merged 1 commit into
mainfrom
fix/revendor-platform-tokens
Sep 13, 2026
Merged

gianlucamazza merged 1 commit into
mainfrom
fix/revendor-platform-tokens

Conversation

@gianlucamazza

@gianlucamazza gianlucamazza commented Sep 13, 2026

Copy link
Copy Markdown
Owner

test_tokens_match_platform has been failing on main (noted in #103) since mklang-platform 1e80671 added six --surface-* tokens to web/shared/tokens.css. This re-vendors the :root block exactly as the test's message instructs; the file header is unchanged.

The test skips on CI (private sibling repo), so only a local checkout with both repos could see the drift.

Checks: tests/repo/test_brand_assets.py 4 passed; full suite 682 passed, 1 skipped.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Added new color options for surfaces and controls.
    • Added a stronger focus-ring style for improved keyboard focus visibility.
    • Added text-measure options to support more consistent line lengths across content.

`tests/repo/test_brand_assets.py::test_tokens_match_platform` has been red on
main since mklang-platform 1e80671 ("redesign platform web surfaces") added
`--surface-overlay`, `--surface-control` and friends to `web/shared/tokens.css`.
The docs skin's copy is the `:root` block re-vendored as the test's own message
says; the header stays ours.

The test skips on CI (the platform repo is private), which is why only a local
gate with both checkouts saw it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fd340085-d231-4c80-9a78-d7bda3acccd9

📥 Commits

Reviewing files that changed from the base of the PR and between a6447cb and 0ced6a6.

📒 Files selected for processing (1)
  • docs/assets/stylesheets/tokens.css

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The CSS token set adds three surface colors, one strong focus-ring style, and two text-measure values.

Changes

Design token additions

Layer / File(s) Summary
CSS token definitions
docs/assets/stylesheets/tokens.css
Adds surface and control color tokens, a double-ring --focus-ring-strong token, and two text-measure tokens.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0ced6

The token additions align with the platform synchronization objective and targeted and full tests pass.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the docs skin’s vendored platform tokens.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/revendor-platform-tokens

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gianlucamazza
gianlucamazza merged commit 7563cab into main Sep 13, 2026
15 checks passed
@gianlucamazza
gianlucamazza deleted the fix/revendor-platform-tokens branch September 13, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant