Skip to content

Add TypeScript typecheck script and run typecheck in frontend CI - #122

Draft
AdrianOrlow wants to merge 1 commit into
mainfrom
codex/create-pr-from-issue-104-branch
Draft

Add TypeScript typecheck script and run typecheck in frontend CI#122
AdrianOrlow wants to merge 1 commit into
mainfrom
codex/create-pr-from-issue-104-branch

Conversation

@AdrianOrlow

Copy link
Copy Markdown
Member

Motivation

  • Enforce TypeScript correctness during CI to catch type errors early in the frontend pipeline.
  • Ensure the codebase is compatible with stricter tsc checks by removing unused imports that would fail typechecking.

Description

  • Add a typecheck npm script that runs tsc -b by updating package.json.
  • Insert a Typecheck step that runs yarn typecheck before the Build step in both the build and unit jobs of .github/workflows/build-frontend.yml.
  • Fix a test file by removing an unused default React import in src/components/ui/Select/ActionList/ActionList.test.tsx so tsc does not report TS6133.

Testing

  • Ran yarn typecheck, which initially failed with TS6133 due to an unused React import.
  • After removing the unused import, yarn typecheck was run again and completed successfully.

Codex Task

@github-actions

Copy link
Copy Markdown

Coverage Report

Coverage after merging codex/create-pr-from-issue-104-branch into main will be:

Hit/ Total Coverage
🟰 Statements 335 / 335 100% 🥳
🌿 Branches 412 / 412 100% 🥳
🔢 Functions 87 / 87 100% 🥳
📝 Elements 834 / 834 100% 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant