Add TypeScript typecheck script and run typecheck in frontend CI - #122
Draft
AdrianOrlow wants to merge 1 commit into
Draft
Add TypeScript typecheck script and run typecheck in frontend CI#122AdrianOrlow wants to merge 1 commit into
AdrianOrlow wants to merge 1 commit into
Conversation
Coverage ReportCoverage after merging
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tscchecks by removing unused imports that would fail typechecking.Description
typechecknpm script that runstsc -bby updatingpackage.json.Typecheckstep that runsyarn typecheckbefore theBuildstep in both thebuildandunitjobs of.github/workflows/build-frontend.yml.Reactimport insrc/components/ui/Select/ActionList/ActionList.test.tsxsotscdoes not reportTS6133.Testing
yarn typecheck, which initially failed withTS6133due to an unusedReactimport.yarn typecheckwas run again and completed successfully.Codex Task