Fix fragment field-merging validation and reduce allocations - #3085
Open
ghostdogpr wants to merge 1 commit into
Open
Fix fragment field-merging validation and reduce allocations#3085ghostdogpr wants to merge 1 commit into
ghostdogpr wants to merge 1 commit into
Conversation
ghostdogpr
force-pushed
the
codex/fix-fragment-field-merging
branch
from
August 6, 2026 09:05
516fe8a to
3af64e9
Compare
ghostdogpr
force-pushed
the
codex/fix-fragment-field-merging
branch
from
August 6, 2026 09:10
3af64e9 to
4812873
Compare
ghostdogpr
marked this pull request as ready for review
August 6, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, nested fields with the same response name but incompatible leaf types could pass validation beneath mutually-exclusive fragments. Recursing with only the first field type also dropped child fields when the two return object types differed. The validator now resolves and compares both sides independently, while retaining fragment names for O(1) pair memoization.
Benchmarks
Like-for-like JMH runs on JDK 25: 2 forks, 5 one-second warmups, 8 two-second measurement iterations per fork, with GC profiling. Scores show throughput with the JMH 99.9% confidence interval.
Verification