Repository navigation
Attachment support for svelte 5.29+ - #185
Open
SteelAlloy wants to merge 2 commits into
Open
SteelAlloy wants to merge 2 commits into
SteelAlloy wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
With the release of Svelte 5.29,
svelte-copycan now be used through the new attachment API, including on components.The Svelte documentation recommends attachments over actions where possible:
A consumer can already use
svelte-copyas an attachment via thefromActionhelper:However, I think it would be useful for this library to expose a first-class attachment API directly, rather than requiring every consumer to wrap the action with
fromAction.Potential breaking change
In this MR, I renamed the existing
copyaction tocopyActionand madecopythe attachment export.I chose this naming because
copyAttachmentfelt unnecessarily verbose, whilecopyis the most natural name for the primary API going forward. Actions would remain available ascopyActionfor backward compatibility and existing codebases.That said, I understand that renaming the existing
copyexport could be considered too disruptive. If maintaining the currentcopyaction export is preferred, we can instead expose the attachment under a separate name. Naming suggestions are welcome.Documentation
The documentation has been updated accordingly: