Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Features/style changes#15

Open
Benjamin23 wants to merge 10 commits into
ghinda:masterfrom
Benjamin23:features/style-changes
Open

Features/style changes#15
Benjamin23 wants to merge 10 commits into
ghinda:masterfrom
Benjamin23:features/style-changes

Conversation

@Benjamin23

Copy link
Copy Markdown

Hi,

Here is a list of changes that I've made:

  1. Replaced grunt with gulp.
  2. Added options to pass font sizes and font families to the directive
  3. Added alignment options to the toolbar
  4. Added color picker option
  5. Some minor refactoring in the editor directive
  6. Fixed issue with font size and familiy on android devices

@ghinda

ghinda commented Oct 10, 2017

Copy link
Copy Markdown
Owner

Hi,

A couple of quick notes:

  • I'm ok with replacing Grunt with Gulp, it's just that the gulpfile is missing a couple of things right now:

    • The grunt-buildcontrol task deploys the simple demo site to github pages. It pushes the public folder to the gh-pages branch.
    • The jshint task.
  • I want to keep the dist folder in the repo, so people can just install the package and not have to use a build tool to use it.

@ghinda

ghinda commented Nov 9, 2017

Copy link
Copy Markdown
Owner

I replaced gulp with grunt and reversed some of the configs. I kept all the new features you added.

It's on a different branch:
https://github.com/ghinda/angular-meditor/tree/features/style-changes

Found a couple of issues:

  • On Firefox, the size always reverts to the original size after changing it
  • Dropdowns stay open when clicking outside or selecting an item. They close only when clicking the main toggle button. Could you change the custom dropdowns with native select elements?
  • Could you detect the color of the selected text, and set it as the color input color when the toolbar appears?

Any chance you could make these changes? Make sure to rebase from the new branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants