Gas estimation for Zero knowledge precompile#151
Conversation
Cargo.toml
Outdated
|
|
||
| # Frontier Primitive | ||
| fc-storage = { version = "1.0.0-dev", git = "https://github.com/AstarNetwork/frontier.git", branch = "polkadot-v0.9.40", default-features = false } | ||
| fp-account = { version = "1.0.0-dev", git = "https://github.com/AstarNetwork/frontier.git", branch = "polkadot-v0.9.40", default-features = false } |
There was a problem hiding this comment.
@luckychacha Why do we enclude this from the outside repo. Can we for it maybe? @xcthulhu What do you think? Otherwise we will have a potential security hole if our installation depends on third part githubs
There was a problem hiding this comment.
- The dependency
fp-accountin my requirements is used to build the mock runtime for benchmark's unit tests, and thus is placed under[dev-dependencies]in theruntime-commonmodule. It will not be included in the release version. Moreover, I have found alternative ways to build the mock runtime, so I will remove thefp-account.workspace = trueentry from theruntime-common'sCargo.tomlfile under[dev-dependencies]. - I have noticed that our cargo.toml file contains a patch for this dependency, pointing to our forked
frontierproject:
# Temporary, leaks the std feature in the non-std env. Until https://github.com/AstarNetwork/frontier/pull/84 is merged.
[patch."https://github.com/AstarNetwork/frontier.git"]
fp-account = { git = "https://github.com/GoldenGateGGX/frontier.git", branch = "polkadot-v0.9.40" }
This patch ensures that we are actually utilizing our own forked version of the frontier project rather than the one under AstarNetwork.
uchu
left a comment
There was a problem hiding this comment.
Please see why we include code from AstarNetwork instead of forking it and including from our own repo
…/ggxchain/ggxnode into gas-estimation-for-zk-precompile
No much sense to be honest to fork everything we use. We don't plan to adjust it, so why bother forking. |
No description provided.