Repository navigation
fix: concurrent-run MCP test flake, one to_zone, doctor $TZ warning, README job wording - #40
Merged
Merged
Conversation
…n so concurrent pytest runs stop killing each other's servers
…in_timezone and the dashboard each spelled
… service units do not set
… of the model-independent data plane
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small items left over from the whole-project review and 6b-2b.
pgrep -f, so concurrent pytest runs SIGKILLed each other's servers (3 concurrent runs: 25 failures). Scoped to this process's children withpgrep -P; 3 concurrent runs now pass 50/50 each. Test-only.to_zone()is the one place the naive-UTC → zone conversion is spelled;App.in_timezoneand the dashboard's_in_zoneboth delegate. Behaviour unchanged; mutating it to bare.astimezone()fails three tests underTZ=Pacific/Auckland.$TZis set, doctor warns (exit code still 0): the shipped systemd/launchd units do not set$TZ, so the service may resolve a different zone. Pinned-zone behaviour unchanged.Not addressed:
_check_day_boundarycannot see an operator who pinned a zone different from their old per-app value; that needs a stored marker and is design work.