Skip to content

Release/DX polish: doctor exit codes, py.typed, dependency caps, deploy unit, docs - #38

Merged
ggapp1 merged 14 commits into
mainfrom
fix/release-dx-polish
Oct 29, 2026
Merged

ggapp1 merged 14 commits into
mainfrom
fix/release-dx-polish

Conversation

@ggapp1

@ggapp1 ggapp1 commented Oct 29, 2026

Copy link
Copy Markdown
Owner

The release/DX findings and the remaining security LOWs from the whole-project review. 14 commits.

Code

  • doctor exits 1 when run would fail, and only then. ✗ is reserved for real failures; ⚠ marks risks, ℹ marks normal states (telegram unset, tailscale absent, fresh db). Outside a project it prints one clear "no dudamel.toml" line instead of a cascade. Pending migrations are ℹ with auto_migrate on (startup applies them) and ✗ with it off, matching runtime.py.
  • py.typed ships (asserted in test_wheel_contents.py). App.now() returned object; it now returns Any.
  • Caps raised: uvicorn<1 (was a minor cap at <0.52; serve.py's direct Server.startup/shutdown use is now named in the comment), python-telegram-bot<23 (the cited weakref requirement did not exist). Locked at uvicorn 0.54.0 / ptb 22.8; full suite green. Supersedes Dependabot build(deps): bump python-telegram-bot from 21.11.1 to 22.8 #7 and build(deps): bump uvicorn from 0.51.0 to 0.52.4 #9.
  • systemd unit: ExecStart names uv by absolute path (resolved at scaffold time, falling back to %h/.local/bin/uv), since a lingering --user manager's PATH has no ~/.local/bin. StartLimitIntervalSec=300/StartLimitBurst=5 let a crash loop end in failed.
  • db migrate reports the lanes it applied (stderr; stdout unchanged).
  • doctor names app modules in apps/ that assistant.py never registers. The check reads source text only; it imports nothing new.
  • .gitignore lets CHANGELOG/SECURITY/CONTRIBUTING through. No files are created.
  • Security LOWs: MAX_TOOLS_PER_SERVER = 64 with one counted WARN; the unknown-tool error lists 20 names + "and N more" and goes through the tool-result cap; .env is written via a 0o600 O_EXCL temp file and os.replace, so it is never wider than 0600, even for an instant.

Docs (README)

  • daily_tokens is global, not per-tier; data_dir holds only the instance lockfile.
  • Breaking-changes list completed, each item verified against git show v0.1.0: taint gating MCP mutations, /api/chat channel rule, display-text cleaning, reserved suite names, widget order, dependency floors, timestamped backups, doctor exit code, and a cross-link to the timezone hard-fail.
  • Documented api_key_env, max_tokens, [telegram] token_env/allowed_user_ids/allow_groups, [web] token_env, [router] confirm_ttl_seconds/iteration_cap.
  • The testing snippet now runs; it was extracted from the README and executed.

Full suite incl. slow: 1150 passed locally; ruff check/format clean; uv lock --check consistent.

ggapp1 added 14 commits October 29, 2026 10:51
… a weakref rationale the code never relied on
…t out, and correct the widget-order sentence
…, max_tokens, token_env, allowed_user_ids, allow_groups, confirm_ttl_seconds, iteration_cap)
@ggapp1
ggapp1 merged commit 82c6ad6 into main Oct 29, 2026
6 checks passed
@ggapp1
ggapp1 deleted the fix/release-dx-polish branch October 29, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant