Repository navigation
Release/DX polish: doctor exit codes, py.typed, dependency caps, deploy unit, docs - #38
Merged
Merged
Conversation
…ar line outside a project
…es are visible to type checkers
… a weakref rationale the code never relied on
…dout stays parseable
…goes through the tool-result cap
…od'd after the write
…nly the instance lockfile
…t out, and correct the widget-order sentence
…, max_tokens, token_env, allowed_user_ids, allow_groups, confirm_ttl_seconds, iteration_cap)
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release/DX findings and the remaining security LOWs from the whole-project review. 14 commits.
Code
doctorexits 1 whenrunwould fail, and only then. ✗ is reserved for real failures; ⚠ marks risks, ℹ marks normal states (telegram unset, tailscale absent, fresh db). Outside a project it prints one clear "no dudamel.toml" line instead of a cascade. Pending migrations are ℹ withauto_migrateon (startup applies them) and ✗ with it off, matchingruntime.py.py.typedships (asserted intest_wheel_contents.py).App.now()returnedobject; it now returnsAny.uvicorn<1(was a minor cap at<0.52;serve.py's directServer.startup/shutdownuse is now named in the comment),python-telegram-bot<23(the cited weakref requirement did not exist). Locked at uvicorn 0.54.0 / ptb 22.8; full suite green. Supersedes Dependabot build(deps): bump python-telegram-bot from 21.11.1 to 22.8 #7 and build(deps): bump uvicorn from 0.51.0 to 0.52.4 #9.ExecStartnamesuvby absolute path (resolved at scaffold time, falling back to%h/.local/bin/uv), since a lingering--usermanager's PATH has no~/.local/bin.StartLimitIntervalSec=300/StartLimitBurst=5let a crash loop end infailed.db migratereports the lanes it applied (stderr; stdout unchanged).doctornames app modules inapps/thatassistant.pynever registers. The check reads source text only; it imports nothing new..gitignorelets CHANGELOG/SECURITY/CONTRIBUTING through. No files are created.MAX_TOOLS_PER_SERVER = 64with one counted WARN; the unknown-tool error lists 20 names + "and N more" and goes through the tool-result cap;.envis written via a 0o600O_EXCLtemp file andos.replace, so it is never wider than 0600, even for an instant.Docs (README)
daily_tokensis global, not per-tier;data_dirholds only the instance lockfile.git show v0.1.0: taint gating MCP mutations,/api/chatchannel rule, display-text cleaning, reserved suite names, widget order, dependency floors, timestamped backups, doctor exit code, and a cross-link to the timezone hard-fail.api_key_env,max_tokens,[telegram] token_env/allowed_user_ids/allow_groups,[web] token_env,[router] confirm_ttl_seconds/iteration_cap.Full suite incl. slow: 1150 passed locally; ruff check/format clean;
uv lock --checkconsistent.