Repository navigation
Security fixes from the whole-project review - #36
Merged
Merged
Conversation
…he requester's buttons
…ntrols on the web as on Telegram
…d token until restarted
…ides from its exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five findings from the whole-project review's security lens. One commit each, each with a regression test that fails on
main.resolve_confirmationrefused a foreign resolver only in prose, so_on_callbacktreated the refusal as a resolution and edited the prompt withreply_markup=None— stripping the requester's ✅/❌ off a still-pending confirmation. Needsallow_groups = trueand two allow-listed users.ChatReplynow carriesrefused; a refused tap gets an alert and the message is left untouched, mirroring what_ActionTokens.consumealready does for action buttons.UNSAFE_MARKDOWN_CHARS(the display class minus\n/\t, pinned by a full-codepoint sweep) andclean_markdown; widget titles and error strings are cleaned once inwidgets.py, the producer both surfaces read.httpx.HTTPStatusError.__str__embeds the full URL._redact_exceptionreduces every URL in exception text with the existing label redactor; applied at all five sites (mount, reconnect, stop, teardown, and the error handed to the model). The URL match runs to whitespace/quotes only, so IPv6 hosts and brackets/parentheses in a query cannot end the match early.token rotatenow says it does not revoke a running instance until restart, with the restart commands for the shipped deploy units; README and scaffold README say the same.Fast suite: 1120 passed locally; ruff check and format --check clean.