Repository navigation
Test hardening: kill the mutants the whole-project review found surviving - #35
Merged
Merged
Conversation
…der and url whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mutation-testing pass over the security-critical core found ~28 mutations that survived the whole suite. This PR adds tests that kill every one of them except one equivalent mutant. Test-only:
src/is untouched. Each new test was mutation-checked (the mutation makes it fail; reverted, it passes).monkeypatch.delenv(var, raising=False)records nothing for an absent var, soDUDAMEL_WEB_TOKENwritten by an in-processrunleaked into every later test. That silently voidedtest_missing_configured_token_rejects_any_bearer's precondition: withauth.pymutated to fail open, it passed when run aftertest_cli.py. An autouseos.environsnapshot/restore inconftest.pycloses it; the victim now self-checks its precondition, and the misleading docstrings are corrected.Summaryand the next turn's native write is still gated.upgrade_alltakes a backup.Not killable:
turn_tainted = turn_tainted or summary.taintedinrouter.pyis equivalent, covered by the newest-summary seed and the dropped-span recompute.Fast suite: 1106 passed locally; ruff check and format --check clean.