Improve test coverage from 92.3% to 100% statements#60
Merged
Conversation
Agent-Logs-Url: https://github.com/gfyoung/basic-tts/sessions/122aac58-8f7a-4ec5-9c18-ae9e6792c1e9 Co-authored-by: gfyoung <9273653+gfyoung@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
gfyoung
April 5, 2026 00:27
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several code paths in
basic-tts.jshad no test coverage: thecheckVoicesattempts normalization logic, thespeak()null-utterance rejection path, and the AMDdefineexport block.New test cases
checkVoicesattempts normalization (lines 132, 136)"2") → parsed viaparseInt"abc") →parseIntyieldsNaN→ resets to defaultspeak()with null utterance (line 214)getUtterancereturnsnull→ rejects with"invalid voice"messageAMD define block (lines 266–271)
global.definewithdefine.amd = trueviajest.resetModules()to force re-evaluation of the module-level guarddefine("basic-tts", ...)and anonymousdefine(...)are called with correct factory functionsdefineis not called whendefine.amdis absentCoverage delta
Remaining uncovered branches (lines 40–41, 258) are environment-detection guards (
typeof windowfor browser context, Nodemodule.exportsfalse branch) not reachable in Jest.