Repository navigation
perf(dots): stop reading shared values from JS and crossing to JS on every drag frame #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, and fixed in 70a3989 as suggested: the dots still report only on a new section, and
FastScrollSectionFullListcenters the active section when the list lays out (onLayout), with the same retry a second later thatshow()uses.The touch that opens the list reports its section before the list is mounted, so that
show()cannot scroll it. Before this PR the next frame's report did; with the deduplication the next report only comes on another dot or on lift.Unit test.
centers the section a touch opens the section list on, while the finger stays on its dot: list closed, finger touches Dairy, the list lays out, the finger moves 2 px without leaving Dairy's dot.scrollTois never calledscrollTo({ y: 55 }))yarn test(104 passed, 1 todo),yarn typecheckandyarn lintpass.On device. Android emulator (API 36), Expo Go for SDK 52, dev bundle, Categories screen. The same scripted gesture on both builds: scroll the list a little so the dots show, touch the dot of Necklaces / Silver Gold (low on the bar, far down the section list) with the section list closed, zigzag sideways over that dot for 3.6 s (1.5% of the screen wide, so it never leaves the dot), lift. Times from the touch down, read from the recordings at 5 fps:
At 70a3989 the first scroll, on layout, hits a row the list has not measured yet, and the retry a second later centers it. That is the same timing
show()had when the list was already open.Frames at +0.6, +1.4, +2.4, +3.4 and +4.6 s after the touch down (top: before, bottom: after). The grey circle at the bottom of the dots is the finger:
Full resolution: before.mp4, after.mp4.