Conversation
This was referenced Feb 24, 2025
Merged
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jylamont
marked this pull request as ready for review
February 24, 2025 16:13
jylamont
force-pushed
the
02-24-bug_fixed_tracking_api_key_leaking_in_logs
branch
from
February 24, 2025 17:39
db85187 to
44bb316
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
February 24, 2025 17:39
f5b98f5 to
a722f66
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
February 24, 2025 23:28
a722f66 to
cf891bb
Compare
jylamont
force-pushed
the
02-24-bug_fixed_tracking_api_key_leaking_in_logs
branch
2 times, most recently
from
February 24, 2025 23:29
26f722b to
0f909ab
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
February 24, 2025 23:29
cf891bb to
0df5db5
Compare
jylamont
force-pushed
the
02-24-bug_fixed_tracking_api_key_leaking_in_logs
branch
from
February 25, 2025 16:43
0f909ab to
49cc719
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
2 times, most recently
from
February 25, 2025 17:41
d3a290c to
d01b0a9
Compare
jylamont
force-pushed
the
02-24-bug_fixed_tracking_api_key_leaking_in_logs
branch
from
February 25, 2025 17:41
49cc719 to
47ff710
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
2 times, most recently
from
February 25, 2025 17:54
5cc0b0c to
f873ff0
Compare
jylamont
force-pushed
the
02-24-bug_fixed_tracking_api_key_leaking_in_logs
branch
from
February 25, 2025 17:54
47ff710 to
34513eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on #91, we discovered that the
tracking_api_keywas being leaked in logs (whenconfig.logger = trueand using Rails). This PR properly filters the value from API req logs.