Add component identity to the /status self-report payload - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a self-describing
component: { kind: "php-sdk", version }to the/.well-known/supertab/statuspayload — the PHP counterpart of getsupertab/connect-sdk-typescript#40.Context
The status payload reported only
sdkVersion, which tells the backend nothing about which package a deployment actually updates from. The backend's per-component version resolver (laterpay/supertab-connect#1094) mapscomponent.kindto the right registry and label; a baresdkVersionpayload gets legacy-shimmed tots-sdkand checked against npm — the wrong registry for a Packagist-installed PHP deployment. (The WordPress plugin builds its own status payload withkind: "wordpress-plugin"— getsupertab/connect-wp#18 — so this field covers standalone PHP deployments and the plain-permalink WP fallback where the SDK answers the probe itself.)Key Changes
handleStatusRequest()now emitscomponent: { kind: "php-sdk", version: HttpClient::resolveVersion() }alongside the unchangedsdkVersion.sdkVersion; README payload example updated.Additive and backward-compatible — older backends ignore the new field, and the backend degrades unknown kinds to "show version, no nudge" until it wires a
php-sdkresolver. No version bump or release here; that stays a separate step.