feat: generateLicenseToken for private key assertion - #2
Draft
tomasstark wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for generating a license token via private key JWT client assertion (to match TS SDK capabilities), exposing it as a new static API and wiring it through the customer token client, with accompanying docs and tests.
Changes:
- Introduces
SupertabConnect::generateLicenseToken()(static) andLicenseTokenClient::generateLicenseToken()(instance). - Refactors token exchange internals in
LicenseTokenClient(shared content matching + shared POST/response parsing). - Adds PHPUnit coverage for EC/RSA assertions, claims, request shape, caching, and error cases; updates README with usage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/SupertabConnect.php |
Adds new static entrypoint delegating to LicenseTokenClient. |
src/Customer/LicenseTokenClient.php |
Implements JWT assertion flow + refactors token request/response handling. |
tests/SupertabConnectTest.php |
Adds coverage for the new static method. |
tests/Customer/LicenseTokenClientTest.php |
Adds comprehensive tests for JWT assertion flow. |
README.md |
Documents the new method and provides an example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasstark
marked this pull request as draft
April 1, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
generateLicenseTokento allow for generating a token using private key JWT assertion. This is to reach feature parity with TS SDK.