-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(source-map-config-issues): Adding Sentry Configuration nav item under issues #112811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
086617d
4a5b7f2
549c1be
5fd9677
b7bb007
e2ce168
acd5d22
bc09147
f5d9585
2c1e21e
391b217
751c17b
653b66a
9235abf
ed9bfaa
1e009cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import Feature from 'sentry/components/acl/feature'; | ||
| import {NoProjectMessage} from 'sentry/components/noProjectMessage'; | ||
| import {PageFiltersContainer} from 'sentry/components/pageFilters/container'; | ||
| import {useOrganization} from 'sentry/utils/useOrganization'; | ||
| import {IssueListContainer} from 'sentry/views/issueList'; | ||
| import IssueListOverview from 'sentry/views/issueList/overview'; | ||
| import {ISSUE_TAXONOMY_CONFIG, IssueTaxonomy} from 'sentry/views/issueList/taxonomies'; | ||
|
|
||
| const CONFIG = ISSUE_TAXONOMY_CONFIG[IssueTaxonomy.SENTRY_CONFIGURATION]; | ||
| const QUERY = `is:unresolved issue.category:[${CONFIG.categories.join(',')}]`; | ||
|
|
||
| export default function SentryConfigurationPage() { | ||
| const organization = useOrganization(); | ||
|
|
||
| return ( | ||
| <Feature features={CONFIG.featureFlag ?? []} renderDisabled> | ||
| <IssueListContainer title={CONFIG.label}> | ||
| <PageFiltersContainer> | ||
| <NoProjectMessage organization={organization}> | ||
| <IssueListOverview | ||
| initialQuery={QUERY} | ||
| title={CONFIG.label} | ||
| titleDescription={CONFIG.description} | ||
| /> | ||
| </NoProjectMessage> | ||
| </PageFiltersContainer> | ||
| </IssueListContainer> | ||
| </Feature> | ||
| ); | ||
| } | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -7,6 +7,7 @@ export enum IssueTaxonomy { | |||
| ERRORS_AND_OUTAGES = 'errors-outages', | ||||
| BREACHED_METRICS = 'breached-metrics', | ||||
| WARNINGS = 'warnings', | ||||
| SENTRY_CONFIGURATION = 'sentry-configuration', | ||||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
| } | ||||
|
|
||||
| export const ISSUE_TAXONOMY_CONFIG: Record< | ||||
|
|
@@ -16,6 +17,7 @@ export const ISSUE_TAXONOMY_CONFIG: Record< | |||
| description: ReactNode; | ||||
| key: string; | ||||
| label: string; | ||||
| featureFlag?: string; | ||||
| } | ||||
| > = { | ||||
| [IssueTaxonomy.ERRORS_AND_OUTAGES]: { | ||||
|
|
@@ -47,4 +49,13 @@ export const ISSUE_TAXONOMY_CONFIG: Record< | |||
| 'Issues in your code or configuration that may not break functionality but can degrade performance or user experience' | ||||
| ), | ||||
| }, | ||||
| [IssueTaxonomy.SENTRY_CONFIGURATION]: { | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like by adding this item to sentry/static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx Line 41 in cbeebed
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Laser review man, thanks Added a feature flag gating to the nav item and the route itself |
||||
| categories: [IssueCategory.CONFIGURATION], | ||||
| label: t('Sentry Configuration'), | ||||
| key: 'sentry-configuration', | ||||
| description: t( | ||||
| 'Issues detected from SDK or tooling configuration problems that degrade your ability to debug telemetry using Sentry.' | ||||
| ), | ||||
| featureFlag: 'issue-sourcemap-configuration-visible', | ||||
| }, | ||||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
| }; | ||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might be worth extracting this filter to a helper since its used in multiple places