Skip to content

ref(✂️): bump knip to 6.4 #112764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 6 commits into from
Apr 14, 2026
+9 −19
Merged

ref(✂️): bump knip to 6.4 #112764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a4fc9b
ref: bump knip to v6.4
TkDodo Apr 11, 2026
9363996
remove now unnecessary config overrides
TkDodo Apr 11, 2026
ff9c74b
ref: include more things in knip:prod check as they yield no errors
TkDodo Apr 11, 2026
3425f5d
Merge branch 'master' into tkdodo/ref/knip-6-4
TkDodo Apr 14, 2026
d0ac273
chore: bump knip
TkDodo Apr 14, 2026
acf3c78
Merge branch 'master' into tkdodo/ref/knip-6-4
TkDodo Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions knip.config.ts
View file
Open in desktop
Copy link
Copy Markdown
Collaborator Author

@TkDodo TkDodo Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knip got better at auto-detection so we can remove a bunch of ignoreDependencies from our config

Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ const config: KnipConfig = {
ignoreDependencies: [
'core-js',
'tslib', // subdependency of many packages, declare the latest version
'jest-environment-jsdom', // used as testEnvironment in jest config
'jsdom', // knip thinks we need this because of jest-environment jsdom
'swc-plugin-component-annotate', // used in rspack config, needs better knip plugin
'@swc/plugin-emotion', // used in rspack config, needs better knip plugin
'buffer', // rspack.ProvidePlugin, needs better knip plugin
'process', // rspack.ProvidePlugin, needs better knip plugin
'@babel/preset-env', // Still used in jest
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"https-proxy": "caddy run --config - <<< '{\"apps\":{\"http\":{\"servers\":{\"srv0\":{\"listen\":[\":8003\"],\"routes\":[{\"handle\":[{\"handler\":\"reverse_proxy\",\"upstreams\":[{\"dial\":\"localhost:8000\"}]}]}],\"tls_connection_policies\":[{\"certificate_selection\":{\"any_tag\":[\"cert0\"]}}]}}},\"tls\":{\"certificates\":{\"load_files\":[{\"certificate\":\"./config/localhost.pem\",\"key\":\"./config/localhost-key.pem\",\"tags\":[\"cert0\"]}]}}}}'",
"snapshots": "jest --config jest.config.snapshots.ts",
"knip": "knip --treat-config-hints-as-errors",
"knip:prod": "pnpm run knip --production --exclude dependencies,unresolved"
"knip:prod": "pnpm run knip --production --exclude dependencies"
},
"dependencies": {
"@amplitude/analytics-browser": "^1.5.3",
Expand Down Expand Up @@ -279,7 +279,7 @@
"jest-environment-jsdom": "30.3.0",
"jest-fail-on-console": "3.3.4",
"jest-junit": "16.0.0",
"knip": "6.3.1",
"knip": "6.4.1",
"odiff-bin": "^4.3.2",
"oxfmt": "^0.41.0",
"playwright": "^1.58.2",
Expand Down
20 changes: 7 additions & 13 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading