This repository was archived by the owner on Mar 19, 2026. It is now read-only.
chore: Update Cordova engine version requirements in plugin.xml#411
Merged
Conversation
Contributor
|
@jcesarmobile thank you for the PR! |
Contributor
Author
|
I always recommend using latest versions, specially if submitting to the stores, but not everybody submits to the stores and could need to use an older version because of incompatibilities with older plugins. |
lucas-zimerman
approved these changes
Jan 19, 2026
lucas-zimerman
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the update, I won't consider it as a break change since those versions are 12 years older and likely not supported anymore.
I will consider a bump on them in the future for a major version
At any case, thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
cordovaandcordova-iosversions and comment are based on 0cdd7be#diff-6813833f33103dfcaa583d4f09e06dc84c0ce8ddd34c8b567b56c9728be58389The comments on both were wrong since the version 8 requirement was removed when the package name was changed from
@sentry/cordovatosentry-cordova, so 8 is no longer required. And forcordova-iosit was out of date as it wasn't updated when the version was bumped.For the
cordova-androidversion, the comment is correct, maven libraries support was added incordova-android4.0.0, but it was set to 3.5.0, probably by mistake, not sure if changing the version requirement could be considered a breaking change, but those are ancient versions anyway that nobody should be using nowadays.Changed
that uses gradletothat uses Maven librariesto be more clear about what it means, it means it started adding the sentry maven dependency using the framework tag like this:<framework src="io.sentry:sentry-android:1+" />