Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

chore: Update Cordova engine version requirements in plugin.xml#411

Merged
lucas-zimerman merged 1 commit into
getsentry:mainfrom
jcesarmobile:patch-1
Jan 19, 2026
Merged

chore: Update Cordova engine version requirements in plugin.xml#411
lucas-zimerman merged 1 commit into
getsentry:mainfrom
jcesarmobile:patch-1

Conversation

@jcesarmobile

Copy link
Copy Markdown
Contributor

the cordova and cordova-ios versions and comment are based on 0cdd7be#diff-6813833f33103dfcaa583d4f09e06dc84c0ce8ddd34c8b567b56c9728be58389

The comments on both were wrong since the version 8 requirement was removed when the package name was changed from @sentry/cordova to sentry-cordova, so 8 is no longer required. And for cordova-ios it was out of date as it wasn't updated when the version was bumped.

For the cordova-android version, the comment is correct, maven libraries support was added in cordova-android 4.0.0, but it was set to 3.5.0, probably by mistake, not sure if changing the version requirement could be considered a breaking change, but those are ancient versions anyway that nobody should be using nowadays.

Changed that uses gradle to that uses Maven libraries to be more clear about what it means, it means it started adding the sentry maven dependency using the framework tag like this: <framework src="io.sentry:sentry-android:1+" />

@lucas-zimerman

Copy link
Copy Markdown
Contributor

@jcesarmobile thank you for the PR!
would you say that everyone should be using cordova-android version 14 onwards/ cordova-ios 7.x onwards since they are the minimum required versions to publish an app?

@jcesarmobile

Copy link
Copy Markdown
Contributor Author

I always recommend using latest versions, specially if submitting to the stores, but not everybody submits to the stores and could need to use an older version because of incompatibilities with older plugins.

@lucas-zimerman lucas-zimerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, I won't consider it as a break change since those versions are 12 years older and likely not supported anymore.
I will consider a bump on them in the future for a major version
At any case, thank you for the PR!

@lucas-zimerman lucas-zimerman merged commit 3e905a9 into getsentry:main Jan 19, 2026
13 of 15 checks passed
@jcesarmobile jcesarmobile deleted the patch-1 branch January 19, 2026 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants