Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

chore: Use pull_request_target for changelog preview#410

Merged
lucas-zimerman merged 1 commit into
mainfrom
chore/changelog-preview-target
Jan 19, 2026
Merged

chore: Use pull_request_target for changelog preview#410
lucas-zimerman merged 1 commit into
mainfrom
chore/changelog-preview-target

Conversation

@BYK

@BYK BYK commented Jan 16, 2026

Copy link
Copy Markdown
Member

Summary

Updates the changelog-preview workflow to use pull_request_target instead of pull_request.

Why?

This change is required for the changelog preview to work correctly with PRs from forks. With pull_request, the workflow runs with a read-only GITHUB_TOKEN which cannot post comments or create statuses on fork PRs.

This aligns with the recommended usage in the craft changelog-preview workflow.

Security Note

This change is safe because the changelog-preview workflow:

  • Downloads the Craft binary from releases (not from the PR)
  • Only reads git metadata and configuration
  • Does not execute any code from the PR

@github-actions

Copy link
Copy Markdown
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.
Example:

## Unreleased

### Fixes/Features

- Use pull_request_target for changelog preview ([#410](https://github.com/getsentry/sentry-cordova/pull/410))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 4520635

@lucas-zimerman lucas-zimerman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit 214d69c into main Jan 19, 2026
14 of 15 checks passed
@lucas-zimerman lucas-zimerman deleted the chore/changelog-preview-target branch January 19, 2026 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants