-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(attributes): Add OS context attributes #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8dde20c
feat(attributes): Add OS context attributes
buenaflor 4fe1c20
fix: regenerate attribute files to match source definitions
buenaflor a985209
Merge branch 'main' into buenaflor/feat/add-os-context-attributes
buenaflor 8d6179e
feat(attributes): Add os.build attribute deprecated in favour of os.b…
buenaflor e2622da
fix: Address review feedback for OS attributes
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "key": "os.build", | ||
| "brief": "The build ID of the operating system.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "1234567890", | ||
| "deprecation": { | ||
| "_status": "backfill", | ||
| "replacement": "os.build_id" | ||
| }, | ||
| "alias": ["os.build_id"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [301], | ||
| "description": "Added os.build attribute, deprecated in favor of os.build_id" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "os.kernel_version", | ||
| "brief": "An independent kernel version string. Typically the entire output of the `uname` syscall.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "20.2.0", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [301], | ||
| "description": "Added os.kernel_version attribute" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "os.raw_description", | ||
| "brief": "An unprocessed description string obtained by the operating system. For some well-known runtimes, Sentry will attempt to parse `name` and `version` from this string, if they are not explicitly given.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "Ubuntu 22.04.4 LTS (Jammy Jellyfish)", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [301], | ||
| "description": "Added os.raw_description attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "os.rooted", | ||
| "brief": "Whether the operating system has been jailbroken or rooted.", | ||
| "type": "boolean", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": true, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [301], | ||
| "description": "Added os.rooted attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "key": "os.theme", | ||
| "brief": "Whether the OS runs in dark mode or light mode.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "dark", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [301], | ||
| "description": "Added os.theme attribute" | ||
buenaflor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.