Skip to content

Add isNativeFunction fast path to getImplementation #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7rulnik wants to merge 1 commit into
base: sentry-v2
Choose a base branch
from
Open

Add isNativeFunction fast path to getImplementation #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions packages/rrweb-snapshot/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,15 @@ interface CacheableImplementations {

const cachedImplementations: Partial<CacheableImplementations> = {};

function isNativeFunction(func: unknown): boolean {
return (
typeof func === 'function' &&
/^function\s+\w+\(\)\s+\{\s+\[native code\]\s+\}$/.test(
func.toString(),
)
);
}

function getImplementation<T extends keyof CacheableImplementations>(
name: T,
): CacheableImplementations[T] {
Expand All @@ -450,16 +459,26 @@ function getImplementation<T extends keyof CacheableImplementations>(
return cached;
}

const impl = window[name] as CacheableImplementations[T];

// Fast path to avoid DOM I/O — matches the approach used in
// @sentry-internal/browser-utils getNativeImplementation.
if (isNativeFunction(impl)) {
return (cachedImplementations[name] = impl.bind(
window,
) as CacheableImplementations[T]);
}

let sandboxImpl = impl;
const document = window.document;
let impl = window[name] as CacheableImplementations[T];
if (document && typeof document.createElement === 'function') {
try {
const sandbox = document.createElement('iframe');
sandbox.hidden = true;
document.head.appendChild(sandbox);
const contentWindow = sandbox.contentWindow;
if (contentWindow && contentWindow[name]) {
impl =
sandboxImpl =
// eslint-disable-next-line @typescript-eslint/unbound-method
contentWindow[name] as CacheableImplementations[T];
}
Expand All @@ -469,7 +488,7 @@ function getImplementation<T extends keyof CacheableImplementations>(
}
}

return (cachedImplementations[name] = impl.bind(
return (cachedImplementations[name] = sandboxImpl.bind(
window,
) as CacheableImplementations[T]);
}
Expand Down
25 changes: 22 additions & 3 deletions packages/rrweb/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,15 @@ interface CacheableImplementations {

const cachedImplementations: Partial<CacheableImplementations> = {};

function isNativeFunction(func: unknown): boolean {
return (
typeof func === 'function' &&
/^function\s+\w+\(\)\s+\{\s+\[native code\]\s+\}$/.test(
func.toString(),
)
);
}

function getImplementation<T extends keyof CacheableImplementations>(
name: T,
): CacheableImplementations[T] {
Expand All @@ -635,16 +644,26 @@ function getImplementation<T extends keyof CacheableImplementations>(
return cached;
}

const impl = window[name] as CacheableImplementations[T];

// Fast path to avoid DOM I/O — matches the approach used in
// @sentry-internal/browser-utils getNativeImplementation.
if (isNativeFunction(impl)) {
return (cachedImplementations[name] = impl.bind(
window,
) as CacheableImplementations[T]);
}

let sandboxImpl = impl;
const document = window.document;
let impl = window[name] as CacheableImplementations[T];
if (document && typeof document.createElement === 'function') {
try {
const sandbox = document.createElement('iframe');
sandbox.hidden = true;
document.head.appendChild(sandbox);
const contentWindow = sandbox.contentWindow;
if (contentWindow && contentWindow[name]) {
impl =
sandboxImpl =
// eslint-disable-next-line @typescript-eslint/unbound-method
contentWindow[name] as CacheableImplementations[T];
}
Expand All @@ -654,7 +673,7 @@ function getImplementation<T extends keyof CacheableImplementations>(
}
}

return (cachedImplementations[name] = impl.bind(
return (cachedImplementations[name] = sandboxImpl.bind(
window,
) as CacheableImplementations[T]);
}
Expand Down