chore(rrvideo)!: Remove rrvideo package#276
Merged
Conversation
chargome
force-pushed
the
cg/rm-rrvideo
branch
2 times, most recently
from
62283a9 to
2736091
Compare
jsdom was previously available as a transitive dependency through rrvideo. Multiple packages use @vitest-environment jsdom and need it available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
commented
Apr 9, 2026
| "eslint": "^8.53.0", | ||
| "eslint-plugin-compat": "^4.2.0", | ||
| "eslint-plugin-jest": "^27.6.0", | ||
| "jsdom": "^25.0.0", |
Member
Author
There was a problem hiding this comment.
This was pulled in transitively before, other tests rely on it
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 63f3ad4. Configure here.
andreiborza
approved these changes
Apr 9, 2026
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
LGTM but why the ! in the classification? Doesn't seem like a breaking change to me.
Member
Author
|
theoretically someone could depend on this package from our fork and it would just be gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not use this package internally and it just pulls in a bunch of deps that we do not need.
closes https://linear.app/getsentry/issue/SDK-1121/remove-rrvideo