Skip to content

ref(standalone): Remove old processing code#5805

Open
tobias-wilfert wants to merge 4 commits intomasterfrom
tobias-wilfert/feat/remove-standalone-processor
Open

ref(standalone): Remove old processing code#5805
tobias-wilfert wants to merge 4 commits intomasterfrom
tobias-wilfert/feat/remove-standalone-processor

Conversation

@tobias-wilfert
Copy link
Copy Markdown
Member

@tobias-wilfert tobias-wilfert commented Apr 9, 2026

Follow up to #5741 #5731 #5703 which moved the processing logic for the respective items to own processors. This now removes the old processing standalone code which was only used by standalone form-data (dropped silently).

Ref: https://linear.app/getsentry/issue/INGEST-824/clean-up

@tobias-wilfert tobias-wilfert marked this pull request as ready for review April 9, 2026 14:43
@tobias-wilfert tobias-wilfert requested a review from a team as a code owner April 9, 2026 14:43
Comment on lines -1650 to +1581
Ok(ProcessingResult::no_metrics(
managed_envelope.into_processed(),
))
Err(ProcessingError::NoProcessingGroup)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one "new" logic: We don't forward ungrouped but rather error out here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Standalone FormData now routed to Error pipeline instead of dropped
    • Added explicit handling to silently drop standalone FormData items when there are no event-creating items in the envelope, restoring the previous behavior where they were dropped by process_standalone.

Create PR

Or push these changes by commenting:

@cursor push cf6934e31a
Preview (cf6934e31a)
diff --git a/relay-server/src/services/processor.rs b/relay-server/src/services/processor.rs
--- a/relay-server/src/services/processor.rs
+++ b/relay-server/src/services/processor.rs
@@ -395,6 +395,10 @@
                     Envelope::from_parts(headers.clone(), standalone_profiles),
                 ));
             }
+
+            // Drop standalone FormData items silently.
+            // FormData should only be processed alongside an event-creating item.
+            envelope.take_items_by(|i| matches!(i.ty(), ItemType::FormData));
         }
 
         // Make sure we create separate envelopes for each `RawSecurity` report.

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@tobias-wilfert tobias-wilfert added this pull request to the merge queue Apr 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 9, 2026

INGEST-824 Clean up

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9f006c2. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants