ref(standalone): Remove old processing code#5805
Open
tobias-wilfert wants to merge 4 commits intomasterfrom
Open
ref(standalone): Remove old processing code#5805tobias-wilfert wants to merge 4 commits intomasterfrom
tobias-wilfert wants to merge 4 commits intomasterfrom
Conversation
tobias-wilfert
commented
Apr 9, 2026
Comment on lines
-1650
to
+1581
| Ok(ProcessingResult::no_metrics( | ||
| managed_envelope.into_processed(), | ||
| )) | ||
| Err(ProcessingError::NoProcessingGroup) |
Member
Author
There was a problem hiding this comment.
The one "new" logic: We don't forward ungrouped but rather error out here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Standalone FormData now routed to Error pipeline instead of dropped
- Added explicit handling to silently drop standalone FormData items when there are no event-creating items in the envelope, restoring the previous behavior where they were dropped by process_standalone.
Or push these changes by commenting:
@cursor push cf6934e31a
Preview (cf6934e31a)
diff --git a/relay-server/src/services/processor.rs b/relay-server/src/services/processor.rs
--- a/relay-server/src/services/processor.rs
+++ b/relay-server/src/services/processor.rs
@@ -395,6 +395,10 @@
Envelope::from_parts(headers.clone(), standalone_profiles),
));
}
+
+ // Drop standalone FormData items silently.
+ // FormData should only be processed alongside an event-creating item.
+ envelope.take_items_by(|i| matches!(i.ty(), ItemType::FormData));
}
// Make sure we create separate envelopes for each `RawSecurity` report.This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
jjbayer
approved these changes
Apr 9, 2026
2 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9f006c2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Follow up to #5741 #5731 #5703 which moved the processing logic for the respective items to own processors. This now removes the old processing standalone code which was only used by standalone form-data (dropped silently).
Ref: https://linear.app/getsentry/issue/INGEST-824/clean-up