Skip to content

fix(accessibility): add alt text to PlatformIcon #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natemoo-re merged 4 commits into from
May 27, 2026
Merged

fix(accessibility): add alt text to PlatformIcon #239

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84adc9a
fix(accessibility): add alt text support to PlatformIcon
sentry-junior[bot] May 26, 2026
da39ad9
fix(accessibility): handle decorative composite icon correctly
sentry-junior[bot] May 26, 2026
a329080
Apply suggestion from @ryan953
ryan953 May 26, 2026
245c6b5
Update src/platformIcon.tsx
natemoo-re May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/platformIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,8 @@ type Props = React.HTMLAttributes<HTMLDivElement | HTMLImageElement> & {
radius?: number | null;
withLanguageIcon?: boolean;
languageIconStyles?: React.CSSProperties;
/** Accessible label for the icon. Defaults to the platform name. Pass an empty string to mark the icon as decorative. */
alt?: string;
};

const PlatformIcon = ({
Expand All @@ -311,6 +313,7 @@ const PlatformIcon = ({
withLanguageIcon,
languageIconStyles = {},
style = {},
alt = platform,
...otherProps
}: Props) => {
const icon = getIcon(platform);
Expand All @@ -322,15 +325,22 @@ const PlatformIcon = ({

if (withLanguageIcon && languageIcon !== icon && languageIcon !== "default") {
return (
<div {...otherProps} style={{ position: "relative", ...style }}>
<div
{...otherProps}
role={alt === "" ? undefined : "img"}
aria-label={alt === "" ? undefined : alt}
style={{ position: "relative", ...style }}
>
Comment thread
sentry[bot] marked this conversation as resolved.
<img
src={iconPath}
width={size}
height={size}
alt=""
style={{ borderRadius: `${radius}px` }}
/>
<img
src={languageIconPath}
alt=""
style={{
position: "absolute",
bottom: "-1px",
Expand All @@ -350,6 +360,7 @@ const PlatformIcon = ({
src={iconPath}
width={size}
height={size}
alt={alt}
{...otherProps}
style={{ borderRadius: `${radius}px`, ...style }}
/>
Expand Down
Loading