Skip to content

ref(metrics): remove unused producer broker metrics #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 1 commit into from
Apr 2, 2026
+0 −57
Merged

ref(metrics): remove unused producer broker metrics #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions arroyo/backends/kafka/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,29 +90,6 @@ def producer_stats_callback(stats_json: str, producer_name: Optional[str]) -> No
tags=broker_tags,
)

# Record broker transmission metrics
if broker_stats.get("tx"):
metrics.gauge(
"arroyo.producer.librdkafka.broker_tx",
broker_stats["tx"],
tags=broker_tags,
)

if broker_stats.get("txbytes"):
metrics.gauge(
"arroyo.producer.librdkafka.broker_txbytes",
broker_stats["txbytes"],
tags=broker_tags,
)

# Record broker connection metrics
if broker_stats.get("connects"):
metrics.gauge(
"arroyo.producer.librdkafka.broker_connects",
broker_stats["connects"],
tags=broker_tags,
)

# Record broker transmission error metrics
if broker_stats.get("txerrs"):
metrics.gauge(
Expand Down
9 changes: 0 additions & 9 deletions arroyo/utils/metric_defs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@
# Gauge: Maximum producer message count from librdkafka statistics
# Tagged by producer_name
"arroyo.producer.librdkafka.message_count_max",
# Gauge: Total number of transmission requests from librdkafka statistics
# Tagged by broker_id, producer_name
"arroyo.producer.librdkafka.broker_tx",
# Gauge: Total number of bytes transmitted from librdkafka statistics
# Tagged by broker_id, producer_name
"arroyo.producer.librdkafka.broker_txbytes",
# Gauge: Number of connection attempts to broker from librdkafka statistics
# Tagged by broker_id, producer_name
"arroyo.producer.librdkafka.broker_connects",
# Gauge: Total number of transmission errors from librdkafka statistics
# Tagged by broker_id, producer_name
"arroyo.producer.librdkafka.broker_txerrs",
Expand Down
25 changes: 0 additions & 25 deletions rust-arroyo/src/backends/kafka/producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,31 +68,6 @@ impl ClientContext for ProducerContext {
);
}

// Record broker transmission metrics
gauge!(
"arroyo.producer.librdkafka.broker_tx",
broker_stats.tx as i64,
"broker_id" => broker_id_str.clone(),
"producer_name" => producer_name
);

gauge!(
"arroyo.producer.librdkafka.broker_txbytes",
broker_stats.txbytes as i64,
"broker_id" => broker_id_str.clone(),
"producer_name" => producer_name
);

// Record broker connection metrics (if available)
if let Some(connects) = broker_stats.connects {
gauge!(
"arroyo.producer.librdkafka.broker_connects",
connects as i64,
"broker_id" => broker_id_str.clone(),
"producer_name" => producer_name
);
}

// Record broker transmission error metrics
gauge!(
"arroyo.producer.librdkafka.broker_txerrs",
Expand Down
Loading