Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Test call count not updated after metric removal
- Updated both affected tests to assert the reduced timing call counts that match the remaining p99-only metrics.
Or push these changes by commenting:
@cursor push 1ac364f5d3
Preview (1ac364f5d3)
diff --git a/tests/backends/test_kafka_producer.py b/tests/backends/test_kafka_producer.py
--- a/tests/backends/test_kafka_producer.py
+++ b/tests/backends/test_kafka_producer.py
@@ -24,7 +24,7 @@
producer_stats_callback(stats_json, None)
- assert mock_metrics.timing.call_count == 4
+ assert mock_metrics.timing.call_count == 2
mock_metrics.timing.assert_any_call(
"arroyo.producer.librdkafka.p99_int_latency",
2.0,
@@ -82,7 +82,7 @@
producer_stats_callback(stats_json, None)
- assert mock_metrics.timing.call_count == 6
+ assert mock_metrics.timing.call_count == 3
mock_metrics.timing.assert_any_call(
"arroyo.producer.librdkafka.p99_int_latency",
2.0,This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
3cf1eba to
53240de
Compare
lvthanh03
approved these changes
Mar 24, 2026
fpacifici
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We're only using the
p99_*producer latency metrics in our dashboards & alerting.This removes some of our highest-volume metrics.