Repository navigation
fix(license): require distinct names in composite license rules - #1459
Merged
Merged
Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryTightens two composite-license rules so each match must include both license names.
No actionable issues were found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(license): require distinct names in ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require distinguishing license names in two composite-license rules. Repeated BSD-3-Clause HTML headings now remain BSD-3-Clause instead of disappearing into a BSD-2/BSD-3 clue, and MPL-2.0 headings no longer acquire unrelated Elastic/SSPL licenses.
The regenerated embedded index includes both fixes. Scanner coverage exercises BSD-2, BSD-3, MPL-2.0, Apache-2.0, and Eclipse-2.0 in two page layouts, plus valid BSD and Elastic/SSPL composite notices.
Issues
Closes #1457. Completes the adjacent matching fixes found while investigating #1456.
How to verify
Scan the new
maven-bsd-heading.htmlandmaven-mpl-heading.htmlfixtures undertestdata/license-golden/datadriven/external/with--license --json-pp -. Their detected expressions should bebsd-newandmpl-2.0, respectively, with no composite clues. The neighboringmaven-composite-*fixtures should retainbsd-new AND bsd-simplifiedandelastic-license-v2 OR mongodb-sspl-1.0.Expected-output fixture changes
Four new golden fixtures cover the two heading regressions and two valid composite notices. Existing golden expectations remain unchanged.
🤖 Prepared with Codex.