Repository navigation
Review Image gallery - #2578
Merged
Merged
Review Image gallery#2578
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Image gallery is approved and merged, @mordol. It will be live once the registry publishes.
I added the review timestamp to the record. Your manifest already supplies the description, icon and three screenshots, and your OVERVIEW.md is used as the listing page, so nothing else needed changing. You don't need to do anything.
Next release: nothing worth adding. The overview and screenshots are already in good shape.
Review data
- Artifact:
https://github.com/mordol/paseo-image-galleryat commitb674f32464a4209afb0e6c901abda51e646c86a6(fetched at that exact commit, no submodules or hooks). Plugin at the repository root, manifestpaseo-image-gallery, requires Paseo >=0.16.0. - Scope inspected:
paseo-plugin.json,package.json,OVERVIEW.md,index.server.ts,index.client.tsx,server/gallery.ts,shared/gallery.ts,client/image.ts,client/web.ts, plus a pattern search ofclient/gallery.tsxandclient/viewer.tsx; all four media assets fetched and the grid and viewer screenshots viewed. - Install and dependencies: no install or build command, no lifecycle scripts;
package.jsonhas only dev dependencies (the lockfile is not used at install). - Access and execution: no network calls from plugin code, no subprocesses, no eval or dynamic imports. The server scans timelines of the workspace's non-archived, non-background agents for image paths, URLs and Markdown images.
gallery.readserves only paths returned by the last scan, only for png/jpg/gif/webp/bmp/svg extensions and up to 25 MB, and returns base64 to the Paseo app. Remotehttp(s)images are loaded by the app directly, as the overview states. No credentials, environment secrets or other-plugin storage are read. - Listing: description, icon and screenshots come from the manifest; media URLs resolve to
image/pngat the pinned commit. English overview shipped by the author. - Registry edits:
reviewedAtupdated. Validation: registry validator on main passed (557 records), Validate workflow succeeded on the reviewed head. - Not done: the plugin was not run on a device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2577. Submitted by @mordol.
Ready for artifact review. The reviewer will resolve the submitted source and complete the registry listing.
Submission:
submissions/2577.json.Git references are optional. Use a supplied reference; otherwise resolve main during review. Git updates are submitted manually.