fix(server): disable unsupported summaries for Codex Spark - #2647
Open
astartsky wants to merge 2 commits into
Open
fix(server): disable unsupported summaries for Codex Spark#2647astartsky wants to merge 2 commits into
astartsky wants to merge 2 commits into
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| packages/server/src/server/agent/providers/codex-app-server-agent.ts | Adds a built-in-provider-only Spark compatibility override and resolves configured reasoning summaries for each turn. |
| packages/server/src/server/agent/providers/codex-app-server-agent.test.ts | Covers Spark thread lifecycle behavior, model switching, absent defaults, and preservation of custom-provider settings. |
Reviews (2): Last reviewed commit: "fix(server): preserve custom Codex summa..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #2646
Type of change
What does this PR do
Codex 0.144.4 applies the global reasoning-summary setting to Spark, but
gpt-5.3-codex-sparkrejectsreasoning.summarywith a 400unsupported_parameterresponse.This change scopes the compatibility override to the built-in Codex provider and Spark model:
thread/startandthread/resumereceivemodel_reasoning_summary = "none".turn/startuses the protocol-supportedsummary: "none"override.The per-turn override matters for already-loaded threads:
turn/start.configis not part of the Codex app-server protocol, whileturn/start.summaryis.How did you verify it
Automated coverage in
codex-app-server-agent.test.tsverifies:concise→none→concise);Commands run on the final branch after rebasing onto
origin/main:npm run build:servernpx vitest run packages/server/src/server/agent/providers/codex-app-server-agent.test.ts --bail=1— 119/119 passednpm run typechecknpm run lint— 0 warnings, 0 errorsnpm run format:checkgit diff --check origin/main...HEADReal provider verification:
model_reasoning_summary = "concise".codex/gpt-5.3-codex-sparkagent through Paseo with low thinking and auto-review mode.Reply with exactly SPARK_OK. Do not use tools.SPARK_OK; the daemon log contained nounsupported_parameterorreasoning.summaryfailure for that agent.Checklist
npm run typecheckpassesnpm run lintpassesnpm run formatran