Skip to content

fix(nix): make the v1.8.0 tag buildable - #231

Merged
EtienneLescot merged 2 commits into
release/v1.8.0from
fix/nix-hash-v1.8.0
Aug 3, 2026
Merged

fix(nix): make the v1.8.0 tag buildable#231
EtienneLescot merged 2 commits into
release/v1.8.0from
fix/nix-hash-v1.8.0

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Targets release/v1.8.0, not main — nothing from main comes along.

Why the fix on main isn't enough

src in nix/package.nix is this repo's own tree, not a tarball fetched at a tag. So what a Nix user builds depends on the ref they point at:

Command Builds
nix run github:getopenscreen/openscreen main
nix run github:getopenscreen/openscreen/v1.8.0 this branch's tip

And promote.yml pushes the stable tag on the release branch tip:

https://github.com/getopenscreen/openscreen/blob/main/.github/workflows/promote.yml#L84Push stable tag on the release branch tip

So v1.8.0 would ship the nix/package.nix this branch currently carries, untouched since 2026-07-05:

version     = "1.6.0"
npmDepsHash = "sha256-IZypOLWlDShIjCKWxlJcrdtIkMu0P/DuXaq4c0HW3FY="

bump-nix-package.yml structurally cannot repair that. It fires on release: published, checks out main, and opens its PR against main. The tag is never on its path — it has never once touched a tag.

The value is already proven, not guessed

package-lock.json is byte-identical between this branch and main:

git diff --quiet origin/main origin/release/v1.8.0 -- package-lock.json   # clean

So the correct hash is exactly what CI computed on main in run 30789963366:

sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ=

Version

Straight to 1.8.0. promote.yml rewrites package.json at tag time but never touches nix/package.nix.

With both lines correct here, bump-nix-package.yml hits its git diff --quiet early-exit after the release and no-ops — the workflow becomes a safety net rather than the thing doing the repair after the fact.

Merging this back into main is safe

promote.yml rebase-merges this branch into main afterwards. No commit on this branch touches nix/ other than this one:

git log origin/main..origin/release/v1.8.0 -- nix/    # empty before this PR

So main keeps whatever #230 leaves it with, and this lands on top with the same hash.

Depends on nothing

Independent of #230. #230 fixes main and stops the drift recurring; this makes the v1.8.0 tag buildable. Both are wanted, in either order.

…ers get

promote.yml pushes the stable tag on this branch's tip, and nix/package.nix
here still carries what v1.6.0 left on 2026-07-05. `src` is the repo tree
rather than a fetched tarball, so `nix run github:…/v1.8.0` builds this file
and would refuse the mismatch on sight.

bump-nix-package.yml cannot cover it: it fires after the release is published,
reads main, and opens its PR against main — the tag is never in its path. So
the hash has to be right here, before the tag is cut.

package-lock.json is byte-identical between this branch and main, so the value
is the one CI computed on main in run 30789963366, not a fresh guess:

  sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ=

Version goes straight to 1.8.0 — promote rewrites package.json at tag time but
never touches this file. With both lines correct here, the bump workflow finds
nothing to change after the release and no-ops, which is the intended resting
state rather than a repair.
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7799f158-61d2-4b6c-92bf-a690cf0638f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 2c325e7 into release/v1.8.0 Aug 3, 2026
11 of 12 checks passed
@EtienneLescot
EtienneLescot deleted the fix/nix-hash-v1.8.0 branch August 3, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant