Skip to content

chore: bump nix package to v1.7.0 - #136

Closed
EtienneLescot wants to merge 2 commits into
mainfrom
chore/bump-nix-1.7.0
Closed

chore: bump nix package to v1.7.0#136
EtienneLescot wants to merge 2 commits into
mainfrom
chore/bump-nix-1.7.0

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Automated bump triggered by release v1.7.0 (opened manually — the bot-triggered PR creation failed because GitHub Actions isn't permitted to create PRs on this repo).

  • version1.7.0
  • npmDepsHashsha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s= (computed via prefetch-npm-deps package-lock.json by the bump-nix-package workflow)

Merge this so Nix users (NixOS, Home Manager, nix run github:getopenscreen/openscreen) pick up the new release.

Summary by CodeRabbit

  • Chores
    • Updated the package to version 1.7.0.
    • Refreshed the recorded dependency integrity data for builds.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c67133d3-321c-4572-8ac5-0da76f6e7685

📥 Commits

Reviewing files that changed from the base of the PR and between 46bf3eb and c1cfcc6.

📒 Files selected for processing (1)
  • nix/package.nix

📝 Walkthrough

Walkthrough

The Nix derivation version is bumped from 1.6.0 to 1.7.0, and its npm dependency hash is updated.

Changes

Nix package update

Layer / File(s) Summary
Package version and dependency hash
nix/package.nix
Updates the package version to 1.7.0 and replaces the npmDepsHash value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: enriquefft

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has a summary, but most required template sections are missing, including issue, change type, release impact, testing, and desktop impact. Fill in the template sections for related issue, type of change, release impact, desktop impact, screenshots/video, and testing.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the Nix package version bump to 1.7.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-nix-1.7.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

EtienneLescot added a commit that referenced this pull request Aug 3, 2026
…he PR that causes it

Two failures, one visible and one not.

`gh pr create` ran under GITHUB_TOKEN while the repo has "Allow GitHub
Actions to create and approve pull requests" turned off, so the v1.7.0 bump
pushed its branch and then died on the API call. #136 was opened by hand to
work around it. Every other release workflow already authenticates with
OPENSCREEN_RELEASE_TOKEN, which is not subject to that restriction and whose
PRs trigger CI — so the note telling reviewers to push an empty commit goes
away too.

The quiet one: `src` is this repo's tree rather than a fetched tarball, so
npmDepsHash has to agree with whatever package-lock.json sits beside it, and
the only thing that refreshed it fired on stable releases. main's hash last
matched on 2026-07-05 while the lockfile moved ten more times, leaving
`nix run github:getopenscreen/openscreen` broken for four weeks with nothing
reporting it. A release-time bump structurally cannot cover that gap, so the
check now runs on lockfile and nix/ changes and prints the hash to paste.

Version goes to 1.7.0 here, which is what #136 was for.
EtienneLescot added a commit that referenced this pull request Aug 3, 2026
The value dated to v1.6.0 on 2026-07-05; package-lock.json moved ten times
after that, so `nix build` had been refusing the mismatch ever since. The
replacement is what the new check computed from the current lockfile:

  recorded  sha256-IZypOLWlDShIjCKWxlJcrdtIkMu0P/DuXaq4c0HW3FY=
  expected  sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ=

#136 carried sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=, computed
from main as it stood on 2026-07-19 — stale for the same reason, which is
why merging it would not have fixed anything.
@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

Superseded by #230, which carries the same version1.7.0 bump plus the two fixes this PR couldn't have delivered on its own.

This PR's hash was stale too. It recorded sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=, computed from main as it stood on 2026-07-19. The value the current lockfile actually resolves to is:

sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ=

src here is the repo's own tree rather than a fetched tarball, so npmDepsHash has to track main continuously — and package-lock.json moved 10 times in the two weeks this sat open. Merging it would have left nix build failing, just on a different wrong hash.

#230 also fixes the reason this PR had to be opened by hand (gh pr create running under GITHUB_TOKEN against a repo that forbids Actions from creating PRs), and adds a check that catches hash drift on the PR that causes it instead of at the next release.

Not closing because the work was wrong — closing because the hash inside it has a two-week shelf life and that shelf life is the actual bug.

EtienneLescot added a commit that referenced this pull request Aug 3, 2026
…he PR that causes it

Two failures, one visible and one not.

`gh pr create` ran under GITHUB_TOKEN while the repo has "Allow GitHub
Actions to create and approve pull requests" turned off, so the v1.7.0 bump
pushed its branch and then died on the API call. #136 was opened by hand to
work around it. Every other release workflow already authenticates with
OPENSCREEN_RELEASE_TOKEN, which is not subject to that restriction and whose
PRs trigger CI — so the note telling reviewers to push an empty commit goes
away too.

The quiet one: `src` is this repo's tree rather than a fetched tarball, so
npmDepsHash has to agree with whatever package-lock.json sits beside it, and
the only thing that refreshed it fired on stable releases. main's hash last
matched on 2026-07-05 while the lockfile moved ten more times, leaving
`nix run github:getopenscreen/openscreen` broken for four weeks with nothing
reporting it. A release-time bump structurally cannot cover that gap, so the
check now runs on lockfile and nix/ changes and prints the hash to paste.

Version goes to 1.7.0 here, which is what #136 was for.
EtienneLescot added a commit that referenced this pull request Aug 3, 2026
The value dated to v1.6.0 on 2026-07-05; package-lock.json moved ten times
after that, so `nix build` had been refusing the mismatch ever since. The
replacement is what the new check computed from the current lockfile:

  recorded  sha256-IZypOLWlDShIjCKWxlJcrdtIkMu0P/DuXaq4c0HW3FY=
  expected  sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ=

#136 carried sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=, computed
from main as it stood on 2026-07-19 — stale for the same reason, which is
why merging it would not have fixed anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant