chore: bump nix package to v1.7.0 - #136
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nix derivation version is bumped from 1.6.0 to 1.7.0, and its npm dependency hash is updated. ChangesNix package update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…he PR that causes it Two failures, one visible and one not. `gh pr create` ran under GITHUB_TOKEN while the repo has "Allow GitHub Actions to create and approve pull requests" turned off, so the v1.7.0 bump pushed its branch and then died on the API call. #136 was opened by hand to work around it. Every other release workflow already authenticates with OPENSCREEN_RELEASE_TOKEN, which is not subject to that restriction and whose PRs trigger CI — so the note telling reviewers to push an empty commit goes away too. The quiet one: `src` is this repo's tree rather than a fetched tarball, so npmDepsHash has to agree with whatever package-lock.json sits beside it, and the only thing that refreshed it fired on stable releases. main's hash last matched on 2026-07-05 while the lockfile moved ten more times, leaving `nix run github:getopenscreen/openscreen` broken for four weeks with nothing reporting it. A release-time bump structurally cannot cover that gap, so the check now runs on lockfile and nix/ changes and prints the hash to paste. Version goes to 1.7.0 here, which is what #136 was for.
The value dated to v1.6.0 on 2026-07-05; package-lock.json moved ten times after that, so `nix build` had been refusing the mismatch ever since. The replacement is what the new check computed from the current lockfile: recorded sha256-IZypOLWlDShIjCKWxlJcrdtIkMu0P/DuXaq4c0HW3FY= expected sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ= #136 carried sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=, computed from main as it stood on 2026-07-19 — stale for the same reason, which is why merging it would not have fixed anything.
|
Superseded by #230, which carries the same This PR's hash was stale too. It recorded
#230 also fixes the reason this PR had to be opened by hand ( Not closing because the work was wrong — closing because the hash inside it has a two-week shelf life and that shelf life is the actual bug. |
…he PR that causes it Two failures, one visible and one not. `gh pr create` ran under GITHUB_TOKEN while the repo has "Allow GitHub Actions to create and approve pull requests" turned off, so the v1.7.0 bump pushed its branch and then died on the API call. #136 was opened by hand to work around it. Every other release workflow already authenticates with OPENSCREEN_RELEASE_TOKEN, which is not subject to that restriction and whose PRs trigger CI — so the note telling reviewers to push an empty commit goes away too. The quiet one: `src` is this repo's tree rather than a fetched tarball, so npmDepsHash has to agree with whatever package-lock.json sits beside it, and the only thing that refreshed it fired on stable releases. main's hash last matched on 2026-07-05 while the lockfile moved ten more times, leaving `nix run github:getopenscreen/openscreen` broken for four weeks with nothing reporting it. A release-time bump structurally cannot cover that gap, so the check now runs on lockfile and nix/ changes and prints the hash to paste. Version goes to 1.7.0 here, which is what #136 was for.
The value dated to v1.6.0 on 2026-07-05; package-lock.json moved ten times after that, so `nix build` had been refusing the mismatch ever since. The replacement is what the new check computed from the current lockfile: recorded sha256-IZypOLWlDShIjCKWxlJcrdtIkMu0P/DuXaq4c0HW3FY= expected sha256-SggSPoDnKzmvgXpIGP11y6h390SkoZszeMjFTaokRjQ= #136 carried sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=, computed from main as it stood on 2026-07-19 — stale for the same reason, which is why merging it would not have fixed anything.
Automated bump triggered by release
v1.7.0(opened manually — the bot-triggered PR creation failed because GitHub Actions isn't permitted to create PRs on this repo).version→1.7.0npmDepsHash→sha256-cb8loUzQs4fz3um0xbYgtjQdcRZh/Ptk2YPgv3FHP/s=(computed viaprefetch-npm-deps package-lock.jsonby the bump-nix-package workflow)Merge this so Nix users (NixOS, Home Manager,
nix run github:getopenscreen/openscreen) pick up the new release.Summary by CodeRabbit