Skip to content

feat: add Fedora RPM packaging support #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mundo-Dev0ps wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

feat: add Fedora RPM packaging support #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,11 @@ jobs:
- name: Setup Node.js
uses: ./.github/actions/setup

- name: Install pacman build dependencies
run: sudo apt-get update && sudo apt-get install -y libarchive-tools
- name: Install pacman and rpm build dependencies
# libarchive-tools -> bsdtar, for the pacman target. rpm -> rpmbuild,
# which electron-builder shells out to for the rpm target; without it
# the Linux build fails at the packaging step, not at config parse.
run: sudo apt-get update && sudo apt-get install -y libarchive-tools rpm

- name: Stage whisper-stt binaries
shell: bash
Expand All @@ -338,6 +341,7 @@ jobs:
release/**/*.zsync
release/**/*.deb
release/**/*.pacman
release/**/*.rpm

@coderabbitai coderabbitai Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

python3 - <<'PY'
import json
import re
from pathlib import Path

script = json.loads(Path("package.json").read_text())["scripts"]["build:linux"]

if not re.search(r"(^|\s)rpm(\s|$)", script):
    raise SystemExit("build:linux does not request the rpm target")

print("build:linux requests the rpm target")
PY

Repository: getopenscreen/openscreen

Length of output: 206

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json build scripts =="
python3 - <<'PY'
import json
from pathlib import Path
p = Path("package.json")
s = json.loads(p.read_text())
for key in ("build:linux", "build"):
    if key in s.get("scripts", {}):
        print(f"{key}: {s['scripts'][key]}")
PY

echo
echo "== workflow upload artifacts around line 344 =="
sed -n '310,365p' .github/workflows/build.yml

echo
echo "== occurrences of rpm/rpm-related in workflow =="
rg -n "rpm|if-no-files-found|upload-artifact|electron-builder --linux" .github/workflows/build.yml package.json

Repository: getopenscreen/openscreen

Length of output: 3594

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== package.json build scripts =="
python3 - <<'PY'
import json
from pathlib import Path
p = Path("package.json")
s = json.loads(p.read_text())
for key in ("build:linux", "build"):
    if key in s.get("scripts", {}):
        print(f"{key}: {s['scripts'][key]}")
PY

echo
echo "== workflow upload artifacts around line 344 =="
sed -n '310,365p' .github/workflows/build.yml

 echo
echo "== occurrences of rpm/rpm-related in workflow =="
rg -n "rpm|if-no-files-found|upload-artifact|electron-builder --linux" .github/workflows.build.yml package.json

Repository: getopenscreen/openscreen

Length of output: 2628

Add rpm to the Linux build target list.

.github/workflows/build.yml:344 uploads release/**/*.rpm, but package.json:39 only runs electron-builder --linux AppImage deb pacman --config.npmRebuild=false. This means Linux uploads can succeed without producing the RPM. Add rpm to the Linux targets or add a separate RPM build before upload.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/build.yml at line 344, Update the Linux build command in
package.json to include the rpm target alongside AppImage, deb, and pacman,
ensuring the existing release/**/*.rpm upload pattern has a generated artifact.

if-no-files-found: error
retention-days: 30

Expand Down
3 changes: 2 additions & 1 deletion electron-builder.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@
"target": [
"AppImage",
"deb",
"pacman"
"pacman",
"rpm"
],
"icon": "icons/icons/png",
"artifactName": "${productName}-Linux-${version}.${ext}",
Expand Down
Loading