Feat/parse null into nullopt optionals#654
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves YAML null handling by updating the is_empty check in the Reader to explicitly verify if a node is null. It also introduces a comprehensive test suite covering various data types to ensure null values are handled correctly. One minor improvement was suggested to remove a redundant boolean expression in the test assertions for better clarity.
|
@Fellfalla , the PR looks good to me. Happy to merge this once the tests run through. Thanks for the contribution! |
Tests seem to fail due to flaky pipeline. Is it related to my changes? |
|
@Fellfalla , no, that is because unfortunately vcpkg in Github is indeed a bit flaky. Nothing to do with your changes. |
|
@Fellfalla , I have merged the PR. Thank you very much for your contribution! |
2 participants
Implements the possibility to explicitly write
value: nullfor optionals withstd::nulloptvalues inside yaml files.Related discussion: #652