Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ if (REFLECTCPP_USE_VCPKG)
set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake CACHE STRING "Vcpkg toolchain file")
endif ()

project(reflectcpp VERSION 0.22.0 LANGUAGES CXX)
project(reflectcpp VERSION 0.23.0 LANGUAGES CXX)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Having the version number hardcoded in multiple files (CMakeLists.txt and vcpkg.json) increases the risk of inconsistencies during future version bumps. To improve maintainability, it would be beneficial to establish a single source of truth for the version number. This could be a variable in a single file, with other files being generated from it, or managed via a release script that updates all occurrences. This would make the release process more robust and less error-prone.


if (PROJECT_IS_TOP_LEVEL)
set(REFLECTCPP_INSTALL ON)
Expand Down
2 changes: 1 addition & 1 deletion vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "reflectcpp",
"version-string": "0.22.0",
"version-string": "0.23.0",
"dependencies": [
{
"name": "vcpkg-cmake"
Expand Down
Loading