[[maybe_unused]]

[KostinPavel]

[[maybe_unused]]

[gemini-code-assist]

Summary of Changes

Hello @KostinPavel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality by strategically applying the [[maybe_unused]] attribute to function parameters that, depending on template instantiations or conditional compilation paths, might not be directly referenced. This is a standard C++ practice to prevent unnecessary compiler warnings, ensuring a cleaner build output without impacting the functional aspects of the codebase.

Highlights

• Compiler Warning Suppression: The [[maybe_unused]] attribute has been added to several function parameters across multiple files to explicitly mark them as potentially unused, thereby suppressing compiler warnings.
• Code Cleanliness: This change improves code cleanliness by addressing potential compiler warnings without altering the logic or behavior of the code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds [[maybe_unused]] to several function parameters to suppress compiler warnings about them being unused. While this is appropriate for most of the changes, the change in include/rfl/OneOf.hpp hides a critical bug. In that file, the parameter was unused because the implementation failed to propagate a potentially transformed value, instead returning the original unmodified value. My review includes a critical comment to address this issue.

[gemini-code-assist]

Adding [[maybe_unused]] here silences a compiler warning, but it hides a critical bug. The _result parameter contains the validated value from Head::validate(_value), which may have been transformed during validation (e.g., a string being trimmed). On line 49, the original _value is returned, which discards this potential transformation, leading to incorrect behavior.

The compiler warning about the unused parameter was correctly identifying a symptom of this bug. Instead of suppressing the warning, the bug should be fixed by using _result.

I recommend the following changes:

1. Remove [[maybe_unused]] on this line.
2. On line 49, return _result instead of _value.

Here's how the code should look:

On line 46:

.and_then([&](auto&& _result) -> rfl::Result<T> {

On line 49:

return std::forward<decltype(_result)>(_result);