Skip to content

unused parameters in parsers #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KostinPavel wants to merge 6 commits into from
Closed

unused parameters in parsers #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
820e116
unused parameter Update Parser_vectorstring.hpp
KostinPavel Nov 20, 2025
45e563a
unused parameter Update Parser_bytestring.hpp
KostinPavel Nov 20, 2025
a7c1465
unused parameter Update FieldVariantParser.hpp
KostinPavel Nov 20, 2025
d2147b3
unused parameter Update OneOf.hpp
KostinPavel Nov 20, 2025
4c25d1a
unused parameter Update FieldVariantParser.hpp
KostinPavel Nov 20, 2025
dc18c1c
unused parameters in parsers Update FieldVariantParser.hpp
KostinPavel Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/rfl/OneOf.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct OneOf {
static rfl::Result<T> validate_impl(const T& _value,
std::vector<Error> _errors) {
return Head::validate(_value)
.and_then([&](auto&& _result) -> rfl::Result<T> {
.and_then([&](auto&& /*_result*/) -> rfl::Result<T> {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using /*_result*/ to mark a parameter as unused works, using the [[maybe_unused]] attribute is a more modern and clearer way to express this intent in C++17 and later. It makes the code more self-documenting.

Suggested change
.and_then([&](auto&& /*_result*/) -> rfl::Result<T> {
.and_then([&]([[maybe_unused]] auto&& _result) -> rfl::Result<T> {

if constexpr (sizeof...(Tail) == 0) {
if (_errors.size() == sizeof...(Cs)) {
return _value;
Expand Down
2 changes: 1 addition & 1 deletion include/rfl/parsing/FieldVariantParser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ struct FieldVariantParser {

static schema::Type to_schema(
std::map<std::string, schema::Type>* _definitions,
std::vector<schema::Type> _types = {}) {
std::vector<schema::Type> /*_types = {}*/) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change is problematic. By commenting out _types = {}, you have removed the default argument for this parameter. This is a breaking change for any code that calls this function with only one argument. If the parameter is unused but needs to be kept for API compatibility, please use the [[maybe_unused]] attribute to mark it as such while preserving the function signature, including the default argument.

      std::vector<schema::Type> [[maybe_unused]] _types = {}) {

using VariantType = rfl::Variant<NamedTuple<FieldTypes>...>;
return Parser<R, W, VariantType, ProcessorsType>::to_schema(_definitions);
}
Expand Down
2 changes: 1 addition & 1 deletion include/rfl/parsing/Parser_bytestring.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ struct Parser<R, W, Bytestring, ProcessorsType> {
}

static schema::Type to_schema(
std::map<std::string, schema::Type>* _definitions) {
std::map<std::string, schema::Type>* /*_definitions*/) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using /*_definitions*/ to mark a parameter as unused works, using the [[maybe_unused]] attribute is a more modern and clearer way to express this intent in C++17 and later. It makes the code more self-documenting.

      std::map<std::string, schema::Type>* [[maybe_unused]] _definitions) {

return schema::Type{schema::Type::Bytestring{}};
}
};
Expand Down
2 changes: 1 addition & 1 deletion include/rfl/parsing/Parser_vectorstring.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ struct Parser<R, W, Vectorstring, ProcessorsType> {
}

static schema::Type to_schema(
std::map<std::string, schema::Type>* _definitions) {
std::map<std::string, schema::Type>* /*_definitions*/) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using /*_definitions*/ to mark a parameter as unused works, using the [[maybe_unused]] attribute is a more modern and clearer way to express this intent in C++17 and later. It makes the code more self-documenting.

      std::map<std::string, schema::Type>* [[maybe_unused]] _definitions) {

return schema::Type{schema::Type::Vectorstring{}};
}
};
Expand Down
Loading