[minor] Fix include error of rfl/Literal.hpp#529
Conversation
Summary of ChangesHello @lixin-wei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important build issue by ensuring that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
rfl/Literal.hpprfl/Literal.hpp
There was a problem hiding this comment.
Code Review
This pull request aims to fix a missing include in rfl/Literal.hpp to make it self-contained. The diagnosis is correct, but the wrong header has been included. The file uses std::numeric_limits, which requires the <limits> header, but <climits> was added instead. My review includes a suggestion to correct this.
3fb889f to
1279a85
Compare
1279a85 to
69fca99
Compare
|
@lixin-wei , thanks! |
rfl/Literal.hpp is not self-contained, lacks
<limits>, this PR fixes it.