Skip to content

Added support for std::span; resolves #457#468

Merged
liuzicheng1987 merged 7 commits into
mainfrom
f/span
Jul 20, 2025
Merged

Added support for std::span; resolves #457#468
liuzicheng1987 merged 7 commits into
mainfrom
f/span

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances reflect-cpp by introducing robust support for std::span, enabling its seamless serialization and deserialization. Alongside this new feature, I've clarified the necessary memory management practices for std::span and std::string_view when using the rfl::AllowRawPtrs processor, ensuring users are fully aware of their responsibilities.

Highlights

  • New Container Support: I've added full read and write support for std::span types within the reflect-cpp library.
  • Documentation Updates: I've updated README.md to list std::span and std::string_view as newly supported containers. Crucially, docs/concepts/processors.md now includes detailed warnings and cleanup instructions for std::span and std::string_view when rfl::AllowRawPtrs is used, emphasizing the user's responsibility for memory management.
  • Memory Management Clarification: The library now explicitly warns users about the manual memory deallocation required for std::span and std::string_view when reading with rfl::AllowRawPtrs, aligning their behavior and warnings with raw pointers.
  • New Test Coverage: A dedicated test case has been added to validate std::span serialization and deserialization functionality with the JSON backend.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for std::span, including serialization, deserialization, and documentation updates. There are memory safety issues in the std::span parser and a memory leak in the test case.

Comment thread include/rfl/parsing/Parser_span.hpp
Comment thread tests/json/test_span_read_write.cpp
Comment thread include/rfl/parsing/Parser_span.hpp Outdated
liuzicheng1987 and others added 5 commits July 20, 2025 14:42
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@liuzicheng1987 liuzicheng1987 merged commit f676222 into main Jul 20, 2025
26 of 28 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/span branch July 20, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant