added REFLECTCPP_INSTALL to allow user to control if required

[BestITUserEUW]

Allow the user to control installation of reflectcpp libraries. I need it for this lib kvdb-cpp if a user wants to build with deps i want to install reflect-cpp too even if not being the top level project

[gemini-code-assist]

Summary of Changes

Hello @BestITUserEUW, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build system's flexibility by introducing a dedicated CMake option to control the installation of the reflectcpp library. This change addresses the need for dependent projects to explicitly manage reflectcpp's installation, even when it's not the top-level project, thereby improving integration capabilities for external consumers.

Highlights

• New CMake Option: Introduced a new CMake option, REFLECTCPP_INSTALL, which allows users to explicitly control whether the reflectcpp libraries are installed. This option defaults to PROJECT_IS_TOP_LEVEL but can be overridden.
• Installation Control: The logic for installing reflectcpp has been updated to depend on the new REFLECTCPP_INSTALL option, providing more granular control over the installation process, especially when reflectcpp is used as a subproject.
• CMake Project Declaration: The project() declaration for reflectcpp has been moved from later in the CMakeLists.txt file to the very top, which is a common best practice for CMake projects.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully introduces a new CMake option REFLECTCPP_INSTALL to provide users with explicit control over the installation of reflectcpp libraries, even when it's not the top-level project. The changes are well-implemented, including the appropriate relocation of the project() command to the top of the CMakeLists.txt for better adherence to CMake best practices. The new option's default value correctly leverages PROJECT_IS_TOP_LEVEL, offering sensible behavior while allowing for user override.

[gemini-code-assist]

Moving the project() command to the top of the CMakeLists.txt file, immediately after cmake_minimum_required(), is a good practice. It ensures that project-related variables like PROJECT_VERSION are defined and available throughout the script from the earliest possible point, improving clarity and adherence to common CMake conventions.

[liuzicheng1987]

@BestITUserEUW , thank you!