Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Potentially related (but may have been latent for a while): |
Crosse
reviewed
Feb 27, 2026
Contributor
Crosse
left a comment
There was a problem hiding this comment.
@jay-418, the PowerShell looks fine. The main points I want to make are:
- don't use
exitin a script Write-Errorwill stop the script completely since with$ErrorActionPreferenceset toStop
The rest are cosmetic or edge-case-y.
👍
atavism
reviewed
Feb 27, 2026
Co-authored-by: Seth Wright <seth@crosse.org>
Co-authored-by: Seth Wright <seth@crosse.org>
Co-authored-by: Seth Wright <seth@crosse.org>
Crosse
approved these changes
Feb 28, 2026
atavism
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
background
After being gaslit by Microsoft a couple of times, we switched to the more expensive Signpath for signing, and their subcontracted GlobalSign EV certificate.
important info
admin@lantern.io, approved identity: @jay-418build-windows.ymlhas an input,use-self-signed-cert, which can switch between the self-signed and the signed EV certificate which required an extensively verified identitydeliverables
meet terms terms https://signpath.org/terms(not for an org of our maturity)prod-policy, verify it works before merge