Skip to content

updated Windows code-signing using Signpath#8443

Merged
atavism merged 65 commits intomainfrom
jay/signpath
Mar 2, 2026
Merged

updated Windows code-signing using Signpath#8443
atavism merged 65 commits intomainfrom
jay/signpath

Conversation

@jay-418
Copy link
Contributor

@jay-418 jay-418 commented Feb 4, 2026

background

After being gaslit by Microsoft a couple of times, we switched to the more expensive Signpath for signing, and their subcontracted GlobalSign EV certificate.

important info

  • Signpath account is in 1password, username admin@lantern.io, approved identity: @jay-418
  • build-windows.yml has an input, use-self-signed-cert, which can switch between the self-signed and the signed EV certificate which required an extensively verified identity

deliverables

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jay-418 jay-418 changed the title try signpath for code signing updated Windows code-signing using Signpath Feb 25, 2026
@jay-418
Copy link
Contributor Author

jay-418 commented Feb 26, 2026

Potentially related (but may have been latent for a while):

Copy link
Contributor

@Crosse Crosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-418, the PowerShell looks fine. The main points I want to make are:

  • don't use exit in a script
  • Write-Error will stop the script completely since with $ErrorActionPreference set to Stop

The rest are cosmetic or edge-case-y.

👍

@jay-418 jay-418 requested review from Crosse and atavism February 28, 2026 05:21
@atavism atavism merged commit dd6a317 into main Mar 2, 2026
9 checks passed
@atavism atavism deleted the jay/signpath branch March 2, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants