Repository navigation
feat(currencies): add TND and SYP support - #582
Merged
Merged
Conversation
Add TND to the Currency and CurrencyOrNull enums and rebuild the bundled spec. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
toommz
approved these changes
Sep 17, 2026
## Context SYP (Syrian Pound) is a standard ISO 4217 currency missing from the API currency list. The backend adds it in getlago/lago-api#6433, so the documented enum has to match what the API accepts. ## Description Add SYP to Currency and CurrencyOrNull, and rebuild the bundle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vincent-pochet
added a commit
to getlago/lago-go-client
that referenced
this pull request
Sep 18, 2026
## Context SYP (Syrian Pound) is a standard ISO 4217 currency missing from the Lago currency list. The backend adds it in getlago/lago-api#6433, and the spec in getlago/lago-openapi#582. ## Description Add SYP to the Currency constants so the Go client accepts the same values as the API. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vincent-pochet
changed the title
## Context The committed bundle carried a `components.parameters.currency` entry that a rebuild from `src/` does not produce: the bundler inlines the parameter at each of its five `$ref` sites and prunes the shared component. CI rebuilds the bundle and diffs it against the committed file, so the drift turned the branch red once main moved under it. ## Description Rebuild the bundle from `src/`, dropping the stale component entry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vincent-pochet
added a commit
to getlago/lago-go-client
that referenced
this pull request
Sep 18, 2026
* feat(currencies): add Tunisian Dinar (TND) Add TND to the Currency constants so the client exposes the same currency list as the API. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(currencies): add Syrian Pound (SYP) ## Context SYP (Syrian Pound) is a standard ISO 4217 currency missing from the Lago currency list. The backend adds it in getlago/lago-api#6433, and the spec in getlago/lago-openapi#582. ## Description Add SYP to the Currency constants so the Go client accepts the same values as the API. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
TND (Tunisian Dinar) and SYP (Syrian Pound) are standard ISO 4217 currencies missing from the API currency list. The backend side is handled in getlago/lago-api#6424 for TND (originally contributed as getlago/lago-api#6389) and getlago/lago-api#6433 for SYP; this adds the same values to the spec so the documented enum matches what the API accepts.
Description
TNDtosrc/schemas/Currency.yamlandsrc/schemas/CurrencyOrNull.yaml.SYPto the same two schemas.openapi.yaml(npm run build), which adds both values to the bundled enums.components.parameters.currencyentry the rebuild removes.That last bullet is unrelated drift inherited from
main: the bundler inlines the parameter at each of its five$refsites and prunes the shared component, so the committed bundle no longer matched its own sources and the up-to-date check failed here oncemainmoved.redocly lintpasses on the rebuilt bundle.🤖 Generated with Claude Code