Merged
Conversation
Member
|
Looks good! |
mahagr
reviewed
Jun 14, 2018
|
|
||
| return $this->image->cacheFile($this->format, $this->quality); | ||
| $cachedPath = $this->image->cacheFile($this->format, $this->quality); | ||
| $this->set('filepath', $cachedPath); |
Member
There was a problem hiding this comment.
This line breaks image handling as the image quality gets worse and worse on every resize.
mahagr
pushed a commit
that referenced
this pull request
Jun 15, 2018
Member
|
@tsnorri Can you please try my approach in your use case? |
mahagr
pushed a commit
that referenced
this pull request
Jun 15, 2018
mahagr
pushed a commit
that referenced
this pull request
Jun 15, 2018
Contributor
Author
|
@mahagr Unfortunately I had a rather tight schedule and then forgot about this. I just tested with Grav 1.5.8 and did not get any out-of-memory errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating image derivatives currently keeps all the images in memory until the PHP interpreter is finished. With a substantial number of files or large images this can cause out of memory errors. I attempted to fix the issue by saving the image on disk immediately after the derivative has been created and then freeing it.
Processing large images still takes time. Ideally, multiple threads could be used to create the derivatives, if there is enough memory.
Please note that currently Gregwar\Image\Adapter\GD does not free the associated image resource on deallocation. I've created a pull request to fix this, too. (The checks don't pass because of a configuration error.)