fix(secfile): make Write atomic (temp + fsync + rename)#202
Open
gmoigneu wants to merge 1 commit into
Open
Conversation
secfile.Write was a thin os.WriteFile that left a window where a crash, SIGINT, or full-disk could land a half-written file at the target — destroying the previous content (or any unrelated keys that the codec was supposed to round-trip through, in the MCP / telemetry case). Now writes to a sibling temp file (path.gaal-tmp-<rand>), chmods to 0o600 on the temp, fsyncs, then renames onto the final path. Same- filesystem rename is atomic on POSIX and Windows. The previous direct-WriteFile path is kept as a fallback when temp creation fails (rare; logged at warn). Closes #120. Reliability nets all callers of secfile.Write — MCP codecs (json + toml), telemetry consent persistence, telemetry milestone state, gaal init writes, --log-file open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
secfile.Write(the helper every MCP/telemetry/init writer routes through) now writes to a sibling temp file, fsyncs, and atomically renames onto the target. A crash mid-write cannot leave a half-written file at the destination.