Repository navigation
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the remaining dynamic
WHERE ... IN (SELECT ...)path from #1659.Static IN-list evaluation already exists on main and is left unchanged.
Reproduction And Validation
On main
8b0b4cc021db089722cb3d48dbe915e8e9c532ec, the new real SQL-to-DAG regression failed withFactory(UnsupportedExpression(InSubquery ...)).Current patch, Windows GNU Rust 1.83.0 / protoc 25.3, original lockfile:
The DAG tests run parsed SQL through real sources, processors and a recording sink. They assert output multiplicity and projection, multiple predicates, nested queries, CTEs, and rejection of invalid/correlated subqueries. Processor regressions cover changes on both sides, inner/outer duplicates, NULL/empty sets, mixed numeric equality, independent inputs, and failure rollback. A property test compares randomized insert/delete/NULL event sequences against a multiset reference model for both IN and NOT IN.
rustfmt --checkon the changed Rust files andgit diff --checkpass. This is not a claim that the entire workspace, external connectors, optional feature combinations or production deployment were tested.Short Demo
Actual Rust membership-processor demo (WebM)
Screenshot
The video captures output from an actual local Rust regression run, demonstrating retained outer rows, duplicate inner references and final-reference retractions. It is a processor demonstration, not a cloud/UI deployment; the additional SQL-to-DAG coverage is in the tests.
Limits
Implementation notes are in
dozer-sql/src/selection/membership.md.Prepared and tested with Codex AI assistance; no competing contributor patch was copied. No credentials, real accounts or paid API operations were used.
/claim #1659
Closes #1659