Repository navigation
fix: enable SQL UDFs implemented in WebAssembly (Fixes #1653) - #2544
Open
nghoang1288 wants to merge 1 commit into
Open
nghoang1288 wants to merge 1 commit into
nghoang1288 wants to merge 1 commit into
Conversation
The supplied configuration model accepts only ONNX and JavaScript UDFs, so it cannot represent a WASM UDF; the published schema also requires `udfs` to be an array rather than the mapping proposed in the issue. Resolving this requires configuration support plus module loading, SQL function resolution, return-type inference, and expression evaluation—not merely another evaluator alongside `python_udf.rs`. The expression enum, SQL builder, startup wiring, and Cargo manifests were not supplied, so a complete, compile-valid integration patch cannot be established from these excerpts alone.
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1653
Status
Draft implementation scope. The title describes the intended completed PR; the supplied patch only introduces the WASM configuration model and does not yet resolve the issue.
Summary of changes
The supplied patch adds
UdfType::Wasmand aWasmConfigmodule path, preserving the existing ONNX and JavaScript configuration definitions.The completed implementation must additionally:
wasmfeature through the relevant crates and CLI.env.abortimport as a controlled runtime error.The issue’s
udfs.wasmmapping is incompatible with the currently documented array representation. Supporting that exact syntax requires a backward-compatible configuration deserializer and corresponding schema updates; silently replacing the existing array format would break existing configurations.Root cause
WASM is absent from the supplied UDF configuration enum. Executing WASM from SQL additionally requires integration across configuration loading, SQL planning, and runtime evaluation.
Verification tested
Not run. No repository checkout, build environment, or test runner was available. Compilation and end-to-end behavior are not verified.
Before marking the implementation complete, validation must cover:
env.abort, fuel exhaustion, and memory/table limits.Required context to finish the patch
The workspace and crate Cargo manifests, top-level configuration loader, full expression implementation and error definitions, SQL function builder, CLI/startup UDF wiring, and existing UDF tests are needed to produce the remaining precise changes.
Fixes #1653 once the integration and verification above are complete; the supplied partial patch does not close the issue.