Repository navigation
Add WASM feature gate and stub module to expression crate - #2543
Closed
schwankeith wants to merge 2 commits into
Closed
schwankeith wants to merge 2 commits into
schwankeith wants to merge 2 commits into
Conversation
|
|
Author
|
Closing this PR — on review it isn't up to standard (the change is incomplete and/or unintentionally removes existing code). Sorry for the noise, and thanks for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASM UDF feature requires a conditional compilation module. This change introduces a
wasmfeature gate indozer-sql/expression/lib.rsand adds a stubwasm.rsfile. The stub ensures the crate builds when thewasmfeature is enabled, laying groundwork for future WASM UDF runtime integration.#[cfg(feature = "wasm")] mod wasm;to the expression library.dozer-sql/expression/wasm.rswith a minimal placeholder implementation and a dummy test.This resolves compilation errors when the
wasmfeature is activated and aligns the project structure with the proposed WASM UDF support.Fixes #1653
/claim #1653
Prepared with an AI-assisted workflow; happy to adjust anything in review.