fix: createContact deserialization on empty success response#112
Open
ps-20x wants to merge 1 commit intogetbrevo:v4from
Open
fix: createContact deserialization on empty success response#112ps-20x wants to merge 1 commit intogetbrevo:v4from
ps-20x wants to merge 1 commit intogetbrevo:v4from
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
ContactsClient::createContact()could throw:Brevo\Exceptions\BrevoException: Failed to deserialize response: Syntax errorwhen the API returned a successful response with an empty or blank body.
Root cause
createContact()attempted to deserialize every successful response bodyas JSON without checking whether the body was empty first.
Changes
ContactsClient::createContact()to handle empty successful responses safelyResult
createContact()no longer throws a JSON syntax error for empty successresponses and remains compatible with the current method contract.
Resolves: #104