chore(gh-action): push to master#4
Merged
Merged
Conversation
| if: needs.prepare-matrix.outputs.matrix != '{"service":[]}' | ||
| runs-on: athelas-rops-2c4g | ||
| environment: ${{ github.event.ref == 'refs/heads/main' && 'gcp-artifacts-rw' || 'gcp-artifacts-ro' }} | ||
| environment: ${{ github.event.ref == 'refs/heads/master' && 'gcp-artifacts-rw' || 'gcp-artifacts-ro' }} |
There was a problem hiding this comment.
Bug: The workflow triggers on the main branch but checks for master in its conditional logic, which will prevent Docker images from being published on push.
Severity: HIGH
Suggested Fix
Align the branch names. Either change the trigger branches in the on: block from main to master, or change the conditional checks from refs/heads/master to refs/heads/main to match the trigger.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/containers.yaml#L65
Potential issue: The workflow is configured to trigger on pushes to the `main` branch.
However, the conditional logic for setting the environment and publishing the image
checks if the branch is `refs/heads/master`. Because of this mismatch, when code is
pushed to `main`, the `publish_image` input will evaluate to `false` and the environment
will be set to read-only (`gcp-artifacts-ro`). As a result, Docker images will be built
but will silently fail to publish to the artifact registry.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.