Skip to content

chore(gh-action): push to master#4

Merged
rahulnarla merged 1 commit into
masterfrom
gh_action_master_1
Feb 20, 2026
Merged

chore(gh-action): push to master#4
rahulnarla merged 1 commit into
masterfrom
gh_action_master_1

Conversation

@rahulnarla

Copy link
Copy Markdown
Collaborator

No description provided.

@rahulnarla rahulnarla merged commit d2d3375 into master Feb 20, 2026
1 check passed
if: needs.prepare-matrix.outputs.matrix != '{"service":[]}'
runs-on: athelas-rops-2c4g
environment: ${{ github.event.ref == 'refs/heads/main' && 'gcp-artifacts-rw' || 'gcp-artifacts-ro' }}
environment: ${{ github.event.ref == 'refs/heads/master' && 'gcp-artifacts-rw' || 'gcp-artifacts-ro' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow triggers on the main branch but checks for master in its conditional logic, which will prevent Docker images from being published on push.
Severity: HIGH

Suggested Fix

Align the branch names. Either change the trigger branches in the on: block from main to master, or change the conditional checks from refs/heads/master to refs/heads/main to match the trigger.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/containers.yaml#L65

Potential issue: The workflow is configured to trigger on pushes to the `main` branch.
However, the conditional logic for setting the environment and publishing the image
checks if the branch is `refs/heads/master`. Because of this mismatch, when code is
pushed to `main`, the `publish_image` input will evaluate to `false` and the environment
will be set to read-only (`gcp-artifacts-ro`). As a result, Docker images will be built
but will silently fail to publish to the artifact registry.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant