Skip to content

chore(gh-action): push to master #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulnarla merged 1 commit into from
Feb 20, 2026
Merged

chore(gh-action): push to master #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/containers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ name: Containers
on:
push:
branches:
- main
- master

@sentry sentry Bot Feb 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow trigger was changed to master, but conditional logic for environment and image publishing still checks for the main branch, which will cause failures.
Severity: CRITICAL

Suggested Fix

Update the hardcoded branch references from refs/heads/main to refs/heads/master in the conditional logic for the environment and publish_image steps to align with the new trigger branch.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/containers.yaml#L6

Potential issue: The pull request updates the workflow to trigger on pushes to the
`master` branch instead of `main`. However, it fails to update two conditional checks
that still reference `refs/heads/main`. Specifically, the check for selecting the
`gcp-artifacts-rw` environment and the check for setting the `publish_image` flag will
both evaluate to false on pushes to `master`. This will cause the workflow to use
read-only credentials and prevent the built Docker image from being published, breaking
the CI/CD pipeline for the default branch.

Did we get this right? 👍 / 👎 to inform future reviews.

pull_request:
branches:
- main
- master
types: [opened, synchronize]

permissions:
Expand Down
Loading